My Tribute Page---First Project

Code Feedback
1

Hello everyone!

Here is my Tribute Page https://codepen.io/satishl/full/qBjaryq

It has taken me a bit longer than I had hoped and it feels a bit basic but I have tried to turn it into a basic responsive layout.

If any one has the time I would love some feed back on all aspects, from layout to markup.

Thank you.

4 Likes
2

I like it, you have given it your own style. It’s nice and responsive. I do feel that the page could do with a title . The quote by musk seems to be the title as well. There are a few spelling errors across the page but that is not as important as the page itself which is good.

3

No comments to give this is simply stunning!

4

@Jaydog Thank You for your valuable feedback.

5

@sowg Thank you for your feedback.

6

Simple is always better. I am also working on my assignment atm. I really liked yours. Well done^^ Good luck)))

7

@Aidai19 Thank you for your feedback.

8

Minimal and beautiful :heart: . I would suggest to also change the color of github icon on hover

9

@adramelech Sure!. Thank you for your valuable feedback.

1 Like
10

Hello,

I just came here to post my own project and tell people that, “here’s mine, roast me if you can, gonna need it etc.” than I ve seen your post, and obviously your design.

It is so good that it made me feel bad. So good that, made me remade my own project.
tomorrow I will come back with mine.
cheers
…

well, couldnt wait till tomorrow :laughing:

11

@salvagedscrap Thank you for your valuable feedback. Cheers.

12

Hi @Satish1206,

Your project has some errors:

** HTML

  • The id ‘img’ and ‘img-div’ appears more than once in the document:

  • line : 12

  <div id="img-div" class="col-50">
  • line : 13
   <img id="image" class="image-profile" src="https://i.postimg.cc/sf8Ygff3/elonmusk.jpg" alt="Elon Musk" />
  • line : 72
 <div id="img-div" class="col-50">
  • line : 73
 <img id="image" class="image" src="https://i.postimg.cc/26qs5TdS/tesla.jpg" alt="Elon Musk" />

** CSS

  • line 41:

Unexpected duplicate selector ".col-50", first used at line 34

Notes:
codepen has a feature that lets you to analize HTML, CSS and JS code:

13

@Diego_Perez Thank you for feedback.
Errors is been solved. Can you Please check and let me know.
Also I would love some feed back on all aspects, from layout to markup.
Thanks.

14

This is beautiful. Keep it up.

15

@profsaini Thanks for your valuable feedback.

16

Hi, no errors found using the codepen analizer :+1: .
The project looks good :+1: .

Cheers and happy coding :slight_smile:

17

@Diego_Perez Thank you for your feedback.

1 Like
18

I really liked it :heart:
the only thing that I love to see is big text on big screens because you have a lot of white space in the hero section
fix that button in 800px viewport width
but in the end I liked it

19

@charaf_marghin Fixed that button in 800px viewport width. Please check.
Thanks for your valuable feedback.

20

This topic was automatically closed 182 days after the last reply. New replies are no longer allowed.