My weather viewer for code monkeys - feedback is welcome

My weather viewer for code monkeys - feedback is welcome
0.0 0

#1

I think I’ve got it working fairly well - the only thing I ran into is that the API’s I’m pulling from are on http, so if you view my project over https then it won’t make the call to the API for security reasons - which obviously breaks my site

anyways, here it is: http://codepen.io/GraceNut/full/NRwoPV/ - lemme hear your thoughts :slight_smile:


#2

Very nice. There’s something about pictures of rainy windows that I really like. I also appreciate the appeal to my laziness. Other thoughts, in no particular order:

  • There’s an empty function, toggleDenom. While I love mysteries, it’s probably best to delete it :smiley:
  • You can get around the security limitation by using an HTTPS proxy. https://crossorigin.me is quite popular around here. All you have to do is add that to the beginning of your URL in the $.getJSON function.
  • If I can’t see the weather, what do I see? It would be a good idea to have some sort of fallback message in case the weather isn’t fetched for whatever reason.

#3
  • thanks a bunch for helping me out with the HTTPS issue, I think it’s working properly now
  • that was a good spot, noticing that unused function, thanks for pointing it out :wink:
  • good thoughts about adding in a fallback in case of a lack of data, I’ll work on that one

all the best :slight_smile: