Nikola Tesla: Tribute Page - feedback

Nikola Tesla: Tribute Page - feedback
0.0 0

#1

Hi everyone. This is my first true attempt on creating a page. I would appreciate all kinds of feedback which Im sure theres got to be things that can be improved on the code and style or even everything. I purposelessly didnt include title tags so at least that detail can be neglected. Out of everything the thumbnail’s caption, the thumbnail’s border and making the list looked centered was where I struggled. I searched and read a lot of things that I didnt go through on the lessons on FCC and I avoided asking until now just to push myself on it.

Tribute Page


#2

Hi @jescobar81,

  • This code is not necesary in codepen:
<html>
<head>
<link rel="stylesheet" href="https://maxcdn.bootstrapcdn.com/bootstrap/3.3.7/css/bootstrap.min.css">
<script src="https://ajax.googleapis.com/ajax/libs/jquery/3.1.1/jquery.min.js"></script>
<script src="https://maxcdn.bootstrapcdn.com/bootstrap/3.3.7/js/bootstrap.min.js"></script>

Using Bootstrap With Codepen


  • A bug :bug: (you need the “=” symbol)
 <!--list-->
<div class "row">

  • An empty <div>
<!--list-->
<div class "row">
<div class="col-sm-1"></div> <-- here

Cheers and happy coding :slight_smile:


#3

place your styles into CSS column. Nice work.


#4

Thanks for the replies. I updated the code with the suggestions. Hopefully it looks as similar as the one from the challenge.

@fotonist; At first for some reason the style didn’t want to work in the CSS column. Not sure why but now its working. I’m not sure if its a bug in codepen but I noticed that it has deleted the " / " from some of the tags.

@erretres; I got rid of the unnecessary code. I also got rid of the empty div. I actually had it as a cheat since I couldn’t get the column to align properly but I think I got it figured it out now.