Number Guessing Game - Build a Number Guessing Game

Backend Development
1

Tell us what’s happening:

I have tried everything I could think of to fix this issue, but I just can’t get this one test to pass, can someone help me “If that username has been used before, it should print Welcome back, ! You have played <games_played> games, and your best game took <best_game> guesses., with being a users name from the database, <games_played> being the total number of games that user has played, and <best_game> being the fewest number of guesses it took that user to win the game”

Your code so far

#!/bin/bash

# Define PSQL variable for database queries
PSQL="psql --username=freecodecamp --dbname=number_guess -t --no-align -c"

# Generate the Secret Random Number
SECRET_NUMBER=$(( RANDOM % 1000 + 1 ))

# Prompt for username
echo "Enter your username:"
read USERNAME

# Check if the user exists
USER_INFO=$($PSQL "SELECT user_id, games_played, best_game FROM users WHERE username='$USERNAME'")

if [[ -z $USER_INFO ]]; then
  # New user, insert into database
  echo "Welcome, $USERNAME! It looks like this is your first time here."
  
  # Insert user into the database & ensure correct retrieval
  $PSQL "INSERT INTO users(username, games_played) VALUES('$USERNAME', 0)"
  
  # Fetch the user_id
  USER_ID=$($PSQL "SELECT user_id FROM users WHERE username='$USERNAME'")
  GAMES_PLAYED=0
  #BEST_GAME="NULL" 

else
  # Extract user data properly
  IFS="|" read USER_ID GAMES_PLAYED BEST_GAME <<< "$USER_INFO"
  
  # Print the correct format
  echo "Welcome back, $USERNAME! You have played $GAMES_PLAYED games, and your best game took $BEST_GAME guesses."
fi

# Prompt for the first guess
echo "Guess the secret number between 1 and 1000:"
read GUESS
NUMBER_OF_GUESSES=1

# Validate that the input is an integer
while [[ ! $GUESS =~ ^[0-9]+$ ]]; do
  echo "That is not an integer, guess again:"
  read GUESS
done

# Main guessing loop
while [[ $GUESS -ne $SECRET_NUMBER ]]; do
  (( NUMBER_OF_GUESSES++ ))
  
  if [[ $GUESS -gt $SECRET_NUMBER ]]; then
    echo "It's lower than that, guess again:"
  else
    echo "It's higher than that, guess again:"
  fi

  read GUESS

  while [[ ! $GUESS =~ ^[0-9]+$ ]]; do
    echo "That is not an integer, guess again:"
    read GUESS
  done
done

# User guessed correctly
echo "You guessed it in $NUMBER_OF_GUESSES tries. The secret number was $SECRET_NUMBER. Nice job!"

# Update games played
USER_WIN=$($PSQL "UPDATE users SET games_played = games_played + 1 WHERE user_id = $USER_ID")

# Update best game only if it's NULL or better
if [[ $BEST_GAME == "N/A" || $NUMBER_OF_GUESSES -lt $BEST_GAME ]]; then
  $PSQL "UPDATE users SET best_game = $NUMBER_OF_GUESSES WHERE user_id = $USER_ID"
fi

Your browser information:

User Agent is: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/133.0.0.0 Safari/537.36

Challenge Information:

Number Guessing Game - Build a Number Guessing Game

1 Like
2

Please note that invalid guesses must count as a guess and should increment the total guess value.

3

I just tried that but the test is somehow still failing. This is the updated guess section.

# Prompt for the first guess
echo "Guess the secret number between 1 and 1000:"
read GUESS
NUMBER_OF_GUESSES=1  # Start at 1 to match test expectations

# Validate that the input is an integer and count invalid attempts
while [[ ! $GUESS =~ ^[0-9]+$ ]]; do
  (( NUMBER_OF_GUESSES++ ))  # Count invalid guesses
  echo "That is not an integer, guess again:"
  read GUESS
done

# Main guessing loop
while [[ $GUESS -ne $SECRET_NUMBER ]]; do
  (( NUMBER_OF_GUESSES++ ))  # Count every valid guess attempt

  if [[ $GUESS -gt $SECRET_NUMBER ]]; then
    echo "It's lower than that, guess again:"
  else
    echo "It's higher than that, guess again:"
  fi

  read GUESS
  
  while [[ ! $GUESS =~ ^[0-9]+$ ]]; do
    (( NUMBER_OF_GUESSES++ ))  # Count invalid guesses
    echo "That is not an integer, guess again:"
    read GUESS
  done
done
4

you may have the guesses being one too high than expected

5

I agree with Illenia. Test your code as you are miscounting.

6

I am not following what you mean, I even added debugging print statements, I can’t see where the miscount is happening, can you please give me another clue?

7

you start with 1, then add 1 every time there is a Guess
that means that if there is one guess, you will have a count of 2

8

The welcome section test keeps failing even though the final message passes, so I still don’t get where the miscount or the bug is> I am so confused, here is my updated script guess section.

# Prompt for the first guess
echo "Guess the secret number between 1 and 1000:"
read GUESS
NUMBER_OF_GUESSES=1  # Start at 1 to match test expectations

# Validate that the input is an integer and count invalid attempts
while [[ ! $GUESS =~ ^[0-9]+$ ]]; do
  (( NUMBER_OF_GUESSES++ ))  # Count invalid guesses
  echo "That is not an integer, guess again:"
  read GUESS
done

# Main guessing loop
while [[ $GUESS -ne $SECRET_NUMBER ]]; do
  if [[ $GUESS -gt $SECRET_NUMBER ]]; then
    echo "It's lower than that, guess again:"
  else
    echo "It's higher than that, guess again:"
  fi

  read GUESS
  (( NUMBER_OF_GUESSES++ ))  # Now we count only after the user inputs a valid guess

  while [[ ! $GUESS =~ ^[0-9]+$ ]]; do
    (( NUMBER_OF_GUESSES++ ))  # Count invalid guesses
    echo "That is not an integer, guess again:"
    read GUESS
  done
done
9

why do you start at 1?

10

When I changed the guest count to start at 0, the final message aswell as the welcome message tests fail…

11

can you double check the logic here? when does it increment?

12

This topic was automatically closed 60 days after the last reply. New replies are no longer allowed.