Number Guessing Game - Build a Number Guessing Game

Backend Development
1

Tell us what’s happening:

I need help with this one. I passed the test in test branch then it says I should run it in main branch, after I merge it fails, so does the one in the test branch:
SUBTASKS 1.1 :8 Your script should print the correct welcome message for returning users
If that username has been used before, it should print Welcome back, <username>! You have played <games_played> games, and your best game took <best_game> guesses., with being a users name from the database, <games_played> being the total number of games that user has played

Your code so far

#!/bin/bash

PSQL="psql --username=freecodecamp --dbname=number_guess --tuples-only -c"

echo "Enter your username:"
read USERNAME

if [[ ${#USERNAME} -le 22 ]]
then
  GET_RESULT_USER=$($PSQL "SELECT name, games_played, best_game FROM users WHERE name = '$USERNAME'")

  if [[ -n "$GET_RESULT_USER" ]]
  then
    IFS='|' read -r NAME GAMES_PLAYED BEST_GAME <<< "$GET_RESULT_USER"
    NAME=$(echo "$NAME" | xargs)
    GAMES_PLAYED=$(echo "$GAMES_PLAYED" | xargs)
    BEST_GAME=$(echo "$BEST_GAME" | xargs)
    echo "Welcome back, $NAME! You have played $GAMES_PLAYED games, and your best game took $BEST_GAME guesses."
  else
    echo "Welcome, $USERNAME! It looks like this is your first time here."
    CREATE_USER=$($PSQL "INSERT INTO users(name) VALUES('$USERNAME')")
    GAMES_PLAYED=0
    BEST_GAME=""
  fi

  ((GAMES_PLAYED++))
  SECRET_NUMBER=$(( ( RANDOM % 1000 )  + 1 ))
  echo -e "\nGuess the secret number between 1 and 1000:"

  NUMBER_OF_GUESSES=0

  while true
  do
    ((NUMBER_OF_GUESSES++))
    read INPUT

    INPUT=$(echo "$INPUT" | sed 's/^0*//')
    [[ -z "$INPUT" ]] && INPUT=0

    if [[ ! "$INPUT" =~ ^[0-9]+$ ]] || (( INPUT < 1 || INPUT > 1000 ))
    then
      echo "That is not an integer, guess again:"
      continue
    fi

    if (( INPUT > SECRET_NUMBER ))
    then
      echo "It's lower than that, guess again:"
    elif (( INPUT < SECRET_NUMBER ))
    then
      echo "It's higher than that, guess again:"
    else
      echo "You guessed it in $NUMBER_OF_GUESSES tries. The secret number was $SECRET_NUMBER. Nice job!"

      if [[ -z "$BEST_GAME" || "$BEST_GAME" -gt "$NUMBER_OF_GUESSES" ]]
      then
        UPDATE_GAMES=$($PSQL "UPDATE users SET games_played = $GAMES_PLAYED, best_game = $NUMBER_OF_GUESSES WHERE name='$USERNAME'")
      else
        UPDATE_GAMES=$($PSQL "UPDATE users SET games_played = $GAMES_PLAYED WHERE name='$USERNAME'")
      fi
      break
    fi
  done
fi

Your browser information:

User Agent is: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/132.0.0.0 Safari/537.36 Edg/132.0.0.0

Challenge Information:

Number Guessing Game - Build a Number Guessing Game

2

have you tried running the game and see if the strings printed are as expected?

3

image

this is the output

4

you are not counting these guesses, maybe the error comes from that?

5

Untitled
Untitled868×633 15.8 KB

This is the output when I input the 2nd and 3rd one wrong

6

You could have pointed out where you do the incrementing, I had missed it

7

this is where I do the incrementing

while true
  do
    ((NUMBER_OF_GUESSES++))
    read INPUT

    INPUT=$(echo "$INPUT" | sed 's/^0*//')
    [[ -z "$INPUT" ]] && INPUT=0

    if [[ ! "$INPUT" =~ ^[0-9]+$ ]] || (( INPUT < 1 || INPUT > 1000 ))
    then
      echo "That is not an integer, guess again:"
      continue
    fi
8

I passed the test again in my testing branch :joy: and failed after merge to main without editing anything I just spam Run button:

image
image887×177 7.1 KB

9

This is the Error Output from CodeRoad(Test)

image
image932×195 7.28 KB