Passing user story #10 for personal portfolio

HTML-CSS
1

Tell us what’s happening:
I’m not sure how to make the height of the welcome section equal to the height of the viewport. I also have uneven widths across the entire page, and if you scroll to the right side there is space.

Your code so far
https://codepen.io/xzan1/pen/oNLVbva

Your browser information:

User Agent is: Mozilla/5.0 (X11; CrOS x86_64 13421.99.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/86.0.4240.198 Safari/537.36.

Challenge: Build a Personal Portfolio Webpage

Link to the challenge:

2

Hi @xzan1!

So the height of the viewport needs to be set at 100% of the viewport for the welcome section.
Here is an article on viewport units to help you with that.

But also you have this in your code which is not helping with the test.

  padding: 50px 500px;

Change it to margin and it should pass. But I don’t think you need 500px left-right anyway so I would just leave left-right padding at zero. Maybe that was your way of centering the text but you could just use text-align center for that.

Making that change fixes you horizontal bar problem.

So you are still going to have to take a look at the navbar so it doesn’t spill out over the end there.

The issue is here

 padding: 25px 990px;

That’s a lot of padding for the sides.

Hope that helps!

3

Thank you, and thank you especially for the article!

1 Like