Hello coders and developers. I finished my Product Landing Page
Please give me feedback about my project!!
How is it?
How can I improve the layout and the project in general?
Or Anything to give me feedback
here is my project:
I really liked your webpage…
and that logo beside the FCC test button, I just loved it…
I’d suggest to format the details in #table-compare
section…
and you should style your contact box(email input
and submit button)
Your page looks good @abdulrahman.mhd.anas. Some things to revisit;
- Codepen provides the boilerplate for you. It only expects the code you’d put within the
body
element in HTML. (No need to include thebody
tags). For anything you want to add to the<head>
element click on the ‘Settings’ button, then HTML and add it into the ‘Stuff for <head>’ box. - Run your HTML code through the W3C validator.
- There is an HTML coding error you should be aware of and address.
- Since copy/paste from codepen you can ignore the first warning and first two errors.
- Not concerned so much with the errors in the
meta
keywords (you have too many quotes) but you should be aware that in HTML5 theframeborder
attribute is obsolete.
- Not concerned so much with the errors in the
- Do not use the
<br>
element to force line breaks or spacing. That’s what CSS is for. - Keep like media queries as one instead of scattering throughout. It will make maintenance easier.
- As an aside, the
.section-content
selector has a few fonts that you neitherlink
to (head
element in HTML) orimport
it (CSS). You may have them downloaded on your box others probably will not.
1 Like