Profile lookup - my code is not looking up

JavaScript
1

Tell us what’s happening:
Can anyone help me why this code is not working for returning known values of object properties (the first three questions)?

Your code so far


// Setup
var contacts = [
{
    "firstName": "Akira",
    "lastName": "Laine",
    "number": "0543236543",
    "likes": ["Pizza", "Coding", "Brownie Points"]
},
{
    "firstName": "Harry",
    "lastName": "Potter",
    "number": "0994372684",
    "likes": ["Hogwarts", "Magic", "Hagrid"]
},
{
    "firstName": "Sherlock",
    "lastName": "Holmes",
    "number": "0487345643",
    "likes": ["Intriguing Cases", "Violin"]
},
{
    "firstName": "Kristian",
    "lastName": "Vos",
    "number": "unknown",
    "likes": ["JavaScript", "Gaming", "Foxes"]
}
];


function lookUpProfile(name, prop){
// Only change code below this line
for (let i=0; i<contacts.length; i++){
if (contacts[i]['firstName']===name && contacts[i].hasOwnProperty(prop)===true){
return contacts[i][prop];
} else if (contacts[i]['firstName']!==name){
return 'No such contact';
} else if (contacts[i]['firstName']===name && contacts[i].hasOwnProperty(prop)===false){
return 'No such property';
}
}
// Only change code above this line
}

lookUpProfile("Akira", "likes");

Your browser information:

User Agent is: Mozilla/5.0 (Macintosh; Intel Mac OS X 11_1_0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/87.0.4280.88 Safari/537.36.

Challenge: Profile Lookup

Link to the challenge:

2

Remember that a return statement exits the function. Your code will always return when checking the first item in the array, so no other items will be checked.

3

I thought that as well, and tried to put every result in a variable and then return it at the end, but it still doesn’t work.

What am I missing in order to improve the code as I have written it?

4

There are two conditions under which you want to return:

  • You have found the correct contact.
  • You have looked at every single contact and not found a match.
5

Solved it.

function lookUpProfile(name, prop){
// Only change code below this line
for (let i=0; i<contacts.length; i++){
    if (contacts[i]['firstName']===name && contacts[i].hasOwnProperty(prop)){
        return contacts[i][prop];
    } else if (contacts[i]['firstName']===name && contacts[i].hasOwnProperty(prop)===false) {
        return 'No such property';
    }
}
return 'No such contact';
// Only change code above this line
}
6

Congratulations on working through it!
Happy coding.

1 Like