Profile Lookup (my code is right but why not running)

Tell us what’s happening:

Your code so far


//Setup
var contacts = [
    {
        "firstName": "Akira",
        "lastName": "Laine",
        "number": "0543236543",
        "likes": ["Pizza", "Coding", "Brownie Points"]
    },
    {
        "firstName": "Harry",
        "lastName": "Potter",
        "number": "0994372684",
        "likes": ["Hogwarts", "Magic", "Hagrid"]
    },
    {
        "firstName": "Sherlock",
        "lastName": "Holmes",
        "number": "0487345643",
        "likes": ["Intriguing Cases", "Violin"]
    },
    {
        "firstName": "Kristian",
        "lastName": "Vos",
        "number": "unknown",
        "likes": ["JavaScript", "Gaming", "Foxes"]
    }
];


function lookUpProfile(name, prop){
// Only change code below this line
    for(var i=0;i<contacts.length;i++){
        if(contacts[i].firstName===name && contacts[i].hasOwnProperty(prop)){
            return contacts[i][prop];
        }
        else if(contacts[i].firstName!==name){
            return "No such contact";
        }
        else if(!(contacts[i].hasOwnProperty)(prop)){
            return "No such property";
        }
    }
// Only change code above this line
}

// Change these values to test your function
lookUpProfile("Akira", "likes");

Your browser information:

User Agent is: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/69.0.3497.81 Safari/537.36.

Link to the challenge:
https://learn.freecodecamp.org/javascript-algorithms-and-data-structures/basic-javascript/profile-lookup/

Your code will stop at the first iteration of the loop, as one of the return statements is executed, and when a return statement is executed the function ends

Check the flow of your code with this tool and you will see: http://pythontutor.com/javascript.html

1 Like

Also this is written wrong. hasOwnProperty() doesn’t have the parenthesis for the call where they should be
It should be

!contacts[i].hasOwnProperty(prop)

thanx for your kind suggestion @ilenia