Profile Lookup - Why doesn't my code work?

Profile Lookup - Why doesn't my code work?
0.0 0

#1

Tell us what’s happening:

Hi Guys,

I managed to get the correct solution in the end, with the ‘no such contact’ returning after the if statements had executed, but I can’t quite get my ahead around why my original solution didn’t work?

If anyone can shed some light, I’d be much obliged!

Cheers,
Kohota

Your code so far

//Setup
var contacts = [
    {
        "firstName": "Akira",
        "lastName": "Laine",
        "number": "0543236543",
        "likes": ["Pizza", "Coding", "Brownie Points"]
    },
    {
        "firstName": "Harry",
        "lastName": "Potter",
        "number": "0994372684",
        "likes": ["Hogwarts", "Magic", "Hagrid"]
    },
    {
        "firstName": "Sherlock",
        "lastName": "Holmes",
        "number": "0487345643",
        "likes": ["Intriguing Cases", "Violin"]
    },
    {
        "firstName": "Kristian",
        "lastName": "Vos",
        "number": "unknown",
        "likes": ["Javascript", "Gaming", "Foxes"]
    }
];


function lookUpProfile(firstName, prop){
// Only change code below this line
  for (var i = 0; i < contacts.length; i++) {
    if (contacts[i].firstName === firstName) {
      if (contacts[i].hasOwnProperty(prop)) {
        return contacts[i][prop];
        
      } else {
        return 'No such property';
      }
    } else {
      return 'No such contact'; 
    }
  }
    
// Ony change code above this line
}

// Change these values to test your function
lookUpProfile("Bob", "lastName");

Your browser information:

Your Browser User Agent is: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/61.0.3163.100 Safari/537.36.

Link to the challenge:


#2

You original solution (shown above) does not work, because in the first iteration of the for loop, if the firstName argument does not match contacts[0].firstName, then your else code block returns “No such contact” This solution never goes past the first object in the array before returning a value. Once the return is executed, the function is exited and does not finish the for loop. The first test case of lookUpProfile(“Kristian”, “lastName”); is a perfect example of how your code returns “No such contact” when it should return “Vos”


#3

Ah, great, I keep forgetting that return exits out of the function when it’s reached. Thanks!