Project feedback on Wikipedia viewer

Project feedback on Wikipedia viewer
0.0 0

#1

Just finished my wikipedia viewer, I would really love some reviews


#2
  • You have unclosed div in your HTML (<div class="container"> is not closed).
  • If you wrap input and button with type="submit" in form tag your input field will react to Enter (in this case you’ll need to prevent page refresh on submit with JavaScript).
  • If result contains apostrophe ('), the generated URL is incorrect (search for “cat” and click on “Schrödinger’s cat”).
    I suggest you to use template literals instead of concatenation with +. Like this:
$('.results').append(`<div class="result-title"><a href="${link}">${res.title}</a></div>`);

Fixed version:


#3

Am really grateful for the feedback and for fixing the bug. Thanks @jenovs