Project Feedback! Product and Technical

Code Feedback
1

Hey hey hey!!!

Please take a look at my projects and tell me what you think. I’m sure there are ways to improve them so please let me know!

Technical Documentation
https://codepen.io/lexynr1215/pen/vYyemVR

Product Landing Page
https://codepen.io/lexynr1215/pen/MWbmdXp

2

Pages look good @lexynr1215. Some things to revisit;

tech doc

  • Run your HTML code through the W3C validator.
    • There are HTML coding errors you should be aware of and address.
    • Since copy/paste from codepen you can ignore the first warning and first two errors.
  • Do not use the <br> element to force line breaks or spacing. That’s what CSS is for.
    • Reference MDN Docs
    • You can nest multi-line <code> snippets in <pre> </pre> tags in HTML to preserve whitespace and line breaks.
      Or skip the pre element and do the following in CSS;
       code {
         white-space: pre-line;
       }

prod landing

  • Run your HTML code through the W3C validator.
    • There are HTML coding errors you should be aware of and address.
    • Since copy/paste from codepen you can ignore the first warning and first two errors.
  • Check that the user has entered a valid email addr. Throw an HTML5 validation error if not.
    • You learned to do this when coding the survey form
1 Like
3

Thank you. Phew, just finished correcting all the errors so I think all is good!

4

Good job @lexynr1215. A couple of things;

  • There’s a stray <br> in your tech doc that you should get rid of
  • In the prod landing page there’s no validation error thrown when the email input area is blank and the user clicks submit
5

This topic was automatically closed 182 days after the last reply. New replies are no longer allowed.