Hi, I’m working on the message board project in the information security section and I have completed the code, however, the PUT and DELETE requests are not working.
I’m not sure what is wrong with the delete requests. It doesn’t even return an error, it just returns the console.log("delete", req.body).
However, with the put requests, it doesn’t pass the tests, but when I report a thread, the reported property does change to true.
Here is my code for the routes:
'use strict';
const ThreadModel = require("../models").Thread;
const ReplyModel = require("../models").Reply;
const BoardModel = require("../models").Board;
module.exports = function (app) {
app.route('/api/threads/:board').post((req, res) => {
const { text, delete_password } = req.body;
let board = req.body.board;
if (!board) {
board = req.params.board;
}
console.log("post", req.body);
const newThread = new ThreadModel({
text: text,
delete_password: delete_password,
replies: []
});
console.log("new thread", newThread);
BoardModel.findOne({ name: board }).then(boardData => {
if (!boardData) {
const newBoard = new BoardModel({
name: board,
threads: []
});
console.log("new board", newBoard);
newBoard.threads.push(newThread);
newBoard.save().then(data => {
console.log("new board data", data);
res.json(newThread);
}).catch(err => {
console.log(err);
res.send("There was an error saving post.");
});
} else {
boardData.threads.push(newThread);
boardData.save().then(data => {
console.log("new board data", data);
res.json(newThread);
}).catch(err => {
console.log(err);
res.send("There was an error saving post.");
});
}
}).catch(() => res.send("Could not create board."));
}).get((req, res) => {
const board = req.params.board;
BoardModel.findOne({ name: board }).then(data => {
console.log("data", data);
const threadsObj = data.threads.map(thread => {
const {
_id,
text,
created_on,
bumped_on,
reported,
delete_password,
replies
} = thread;
return {
_id,
text,
created_on,
bumped_on,
reported,
delete_password,
replies,
replycount: replies.length
};
});
res.json(threadsObj);
}).catch(() => res.json({ error: "No board with this name." }));
}).put((req, res) => {
const { thread_id } = req.body;
console.log(thread_id);
const board = req.params.board;
BoardModel.findOne({ name: board }).then((boardData) => {
const date = new Date();
let reportedThread = boardData.threads.id(thread_id);
reportedThread.reported = true;
reportedThread.bumped_on = date;
boardData.save().then(() => {
res.send("Success");
}).catch(() => res.json({ error: "could not report"}));
}).catch(() => res.json({ error: "board not found"}));
}).delete((req, res) => {
console.log("delete", req.body);
const { thread_id, delete_password } = req.body;
const board = req.params.board;
BoardModel.findOne({ name: board }).then(boardData => {
if (boardData.threads.delete_password === delete_password) {
boardData.threads.deleteOne(thread_id);
} else {
res.send("Incorrect Password")
return;
}
boardData.save()
.then(() => res.send("Success"))
.catch(() => res.json({ error: "Could not delete."}));
}).catch(() => res.json({ error: "Board not found"}));
});
app.route('/api/replies/:board').post((req, res) => {
const date = new Date();
const { thread_id, text, delete_password } = req.body;
const board = req.params.board;
const newReply = new ReplyModel({
text: text,
delete_password: delete_password,
created_on: date,
});
BoardModel.findOne({ name: board }).then((boardData) => {
if (!boardData) {
res.json({ error: "Board not found" });
} else {
let repliedThread = boardData.threads.id(thread_id);
repliedThread.bumped_on = date;
repliedThread.replies.push(newReply);
boardData.save().then((updatedData) => {
res.json(updatedData);
}).catch(() => res.json({ error: "could not save"}));
}
}).catch(err => res.json({ error: err }));
}).get((req, res) => {
const board = req.params.board;
BoardModel.findOne({ name: board }).then(data => {
const thread = data.threads.id(req.query.thread_id);
res.json(thread);
}).catch(() => res.json({ error: "Board not found" }))
}).put((req, res) => {
const { thread_id } = req.body;
console.log(thread_id);
const board = req.params.board;
BoardModel.findOne({ name: board }).then((boardData) => {
if (!boardData) {
res.json({error: "Board not found"});
} else {
const date = new Date();
let reportedThread = boardData.threads.id(thread_id);
reportedThread.reported = true;
reportedThread.bumped_on = date;
boardData.save().then(() => {
res.send("reported");
});
}
});
}).delete((req, res) => {
console.log("delete", req.body);
const { thread_id, reply_id, delete_password } = req.body;
const board = req.params.board;
BoardModel.findOne({ name: board }).then(data => {
let thread = data.threads.id(thread_id);
let reply = thread.replies.id(reply_id);
if (reply.delete_password === delete_password) {
thread.replies.deleteOne(reply_id);
} else {
res.send("Incorrect Password");
return;
}
data.save()
.then(() => {
res.send("Success")
})
.catch(() => res.json({ error: "could not delete"}));
}).catch(() => res.json({ error: "could not find board"}));
})
}
Here’s the github link for the rest of my repo: GitHub - jamesnascimento1994/boilerplate-project-messageboard: A boilerplate for a freeCodeCamp project.