Random Quote Generator - Feedback on coding aspect


I’d really appreciate some feedback on the coding aspect of my Random Quote Generator. I’ve not really focussed on any advanced styling as of yet so it is basic (it still passes all of the tests), but I’d like to get some thoughts on how I’ve approached the coding and any tips on how I could make things better/simpler/quicker.

This is my very first attempt at a React app outside of the FCC platform, so I was a little unsure in terms of best practice as to which parts to put in the HTML/CSS/JS sections.

Here is the link: https://codepen.io/mikebish13/pen/WNNWPap

Thanks in advance!


Your code looks pretty clean and readable overall, great work there mate. One thing I’d add to your fetch after the component mounted (line 14) is an error handler, I think (correct me if I’m wrong tho) that as it is now, if will just display your loading screen forever if something wrong happens.

1 Like

Thanks very much!! :+1:

I’ll give that a try.