Responsive Web Design - Portfolio - Problem with vh units

I’m almost done with the personal portfolio challenge. However, the test unit doesn’t accept my solution, even though I think it’s correct.

Problem point: User Story #10: The height of the welcome section should be equal to the height of the viewport.

My code:

#welcome-section {
   height: 100vh;

But the test unit still shows an error regarding this part. Can anybody tell me what can be the reason?

Best regards,

can you give your pen link?

anyway, consider margins, borders and paddings too, those contribute to height as default behaviour

check this

1 Like

Thanks a lot!
Yes, that was it!
I just needed to change the box-sizing property to border-box. And I even knew the difference, just didn’t think about it myself.
Thanks again!


This topic was automatically closed 182 days after the last reply. New replies are no longer allowed.