Scientific Computing with Python Projects - Arithmetic Formatter

Python
1

Tell us what’s happening:
Describe your issue in detail here.

Your code so far

import re
def arithmetic_arranger(problems, solve = False):

  if (len(problems) > 5):
    return "Error: Too many problems"

  first = ""
  second = ""
  lines = ""
  sumx = ""
  string = ""
  for problem in problems:
    if (re.search("[^s0-9.+-]", problem)):
      if (re.search("[/]", problem) or re.search("[*]", problem)):
        return "Error: Operator must be '+' or '-'."
      return "Error: Numbers must be only contain digits."

    firstNumber = problem.split("") [0]
    operator = problem.split("") [1]
    secondNumber = problem.split("") [2]

    if (len(firstNumber) >= 5 or len(secondNumber) >= 5):
      return "Error: Numbers cannot be more than four digits."

    sum = ""
    if (operator == "+"):
      sum = str(int(firstNumber) + int(secondNumber))
    elif (operator == ""):
      sum = str(int(firstNumber) - int(secondNumber))

    length = max(len(firstNumber), len(secondNumber)) + 2
    top = str(firstNumber).rjust(length)
    bottom = operator + str(secondNumber).rjust(length - 1)
    line = ""
    res = str(sum).rjust(length)
    for s in range (length):
      line += "-"

    if problem != problems[-1]:
      first += top + ' '
      second += bottom + ' '
      lines += line + ' '
      sumx += res + ' '

    else:
      first += top
      second += bottom
      lines += line
      sumx += res

  if solve:
    string = first + "\n" + second + "\n" + lines + "\n" + sumx
  else:
    string = first + "\n" + second + "\n" + lines
  return string

Your browser information:

User Agent is: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/106.0.0.0 Safari/537.36

Challenge: Scientific Computing with Python Projects - Arithmetic Formatter

Link to the challenge:

3

What is wrong with the above code?
How can I improve it to work?

4

Please give us more details on your testing of the code. What failed for example? The more details you give the better.

5

Here is the Testing module

import pytest

from arithmetic_arranger import arithmetic_arranger

test_cases = [
pytest.param(
[[‘3801 - 2’, ‘123 + 49’]],
’ 3801 123\n’
‘- 2 + 49\n’
‘------ -----’,
‘Expected different output when calling “arithmetic_arranger()” with [“3801 - 2”, “123 + 49”]’,
id=‘test_two_problems_arrangement1’),
pytest.param(
[[‘1 + 2’, ‘1 - 9380’]],
’ 1 1\n’
‘+ 2 - 9380\n’
‘— ------’,
‘Expected different output when calling “arithmetic_arranger()” with [“1 + 2”, “1 - 9380”]’,
id=‘test_two_problems_arrangement2’),
pytest.param(
[[‘3 + 855’, ‘3801 - 2’, ‘45 + 43’, ‘123 + 49’]],
’ 3 3801 45 123\n’
‘+ 855 - 2 + 43 + 49\n’
‘----- ------ ---- -----’,
‘Expected different output when calling “arithmetic_arranger()” with [“3 + 855”, “3801 - 2”, “45 + 43”, “123 + 49”]’,
id=‘test_four_problems_arrangement’),
pytest.param(
[[‘11 + 4’, ‘3801 - 2999’, ‘1 + 2’, ‘123 + 49’, ‘1 - 9380’]],
’ 11 3801 1 123 1\n’
‘+ 4 - 2999 + 2 + 49 - 9380\n’
‘---- ------ — ----- ------’,
‘Expected different output when calling “arithmetic_arranger()” with [“11 + 4”, “3801 - 2999”, “1 + 2”, “123 + 49”, “1 - 9380”]’,
id=‘test_five_problems_arrangement’),
pytest.param(
[[‘44 + 815’, ‘909 - 2’, ‘45 + 43’, ‘123 + 49’,
‘888 + 40’, ‘653 + 87’]],
‘Error: Too many problems.’,
‘Expected calling “arithmetic_arranger()” with more than five problems to return “Error: Too many problems.”’,
id=‘test_too_many_problems’),
pytest.param(
[[‘3 / 855’, ‘3801 - 2’, ‘45 + 43’, ‘123 + 49’]],
“Error: Operator must be ‘+’ or ‘-’.”,
‘’‘Expected calling “arithmetic_arranger()” with a problem that uses the “/” operator to return “Error: Operator must be ‘+’ or ‘-’.”’‘’,
id=‘test_incorrect_operator’),
pytest.param(
[[‘24 + 85215’, ‘3801 - 2’, ‘45 + 43’, ‘123 + 49’]],
‘Error: Numbers cannot be more than four digits.’,
‘Expected calling “arithmetic_arranger()” with a problem that has a number over 4 digits long to return “Error: Numbers cannot be more than four digits.”’,
id=‘test_too_many_digits’),
pytest.param(
[[‘98 + 3g5’, ‘3801 - 2’, ‘45 + 43’, ‘123 + 49’]],
‘Error: Numbers must only contain digits.’,
‘Expected calling “arithmetic_arranger()” with a problem that contains a letter character in the number to return “Error: Numbers must only contain digits.”’,
id=‘test_only_digits’),
pytest.param(
[[‘3 + 855’, ‘988 + 40’], True],
’ 3 988\n’
‘+ 855 + 40\n’
‘----- -----\n’
’ 858 1028’,
‘Expected solutions to be correctly displayed in output when calling “arithmetic_arranger()” with [“3 + 855”, “988 + 40”] and a second argument of True.’,
id=‘test_two_problems_with_solutions’),
pytest.param(
[[‘32 - 698’, ‘1 - 3801’, ‘45 + 43’, ‘123 + 49’, ‘988 + 40’], True],
’ 32 1 45 123 988\n’
‘- 698 - 3801 + 43 + 49 + 40\n’
‘----- ------ ---- ----- -----\n’
’ -666 -3800 88 172 1028’,
‘Expected solutions to be correctly displayed in output when calling “arithmetic_arranger()” with five arithmetic problems and a second argument of True.’,
id=‘test_five_problems_with_solutions’),
]

@pytest.mark.parametrize(‘arguments,expected_output,fail_message’, test_cases)
def test_template(arguments, expected_output, fail_message):
actual = arithmetic_arranger(*arguments)
assert actual == expected_output, fail_message

6

This topic was automatically closed 182 days after the last reply. New replies are no longer allowed.