I have finished my simon game and would love some input.
Simon Game
- Font-awesome, howler and jQuery are very big libraries for such a tiny app, are you sure you need them?
- IDs should be separated by “-” or “_”
- I see a closing footer tag, but not an opening one. Perhaps use more HTML5 tags in general
- Avoid uppercase variables, if you have to use them at least separate them with a dash or something
- JS files starting usually contain classes, if they don’t user lowercase letters
- I like your approach to styling, your build process allows you to use the most important SASS features, without actually using SASS. I’d give a pre-processor a try if you have already
- You have webpack and gulp? Why?
- Some comments in your code would be nice
Great work! I’m very impressed!
- Font-awsome (forgot i had it wasn’t using it) going to remove it
Howler i was just seeing what it was but will revert to native sound
jQuery is just what i have been using but i could revert it to native js - not exactly sure what this means
- footer tag was mistake, use more tags noted
- I use uppercase only for constants but can see why to avoid it
- Was unaware of this will start to do it this way.
6-7. I use gulp to build my doc folder and to apply postcss and sync my browser.
- Learn JS first, then use jQuery if you need to
- instead of
<label id="strictBtn" class="btn_menu-strict">
do<label id="strict-btn" class="btn_menu-strict">
Also, please a link to the code, not just the live app, when asking for feedback