# Sum All Numbers in a Range Problem

Tell us what’s happening:

``````function sumAll(arr) {

var sum = 0;

for(var i=0; i<arr.length; i++){

sum += Math.max(arr[i]) + Math.min(arr[i]);
}

return sum;
}

sumAll([1, 4]);
``````

Your Browser User Agent is: `Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/65.0.3325.181 Safari/537.36`.

https://www.freecodecamp.org/challenges/sum-all-numbers-in-a-range

Your logic is not correct. Your code only sums each number in the array twice. It is pure coincidence you passed the first test.

The test call of sumAll([5, 10]) is going to do the following:

In first iteration of the for loop, Math.max(arr) is 5, Math.min(arr) is 5, so sum = 0 + 5 + 5 which is 10.

In the second iteration of the for loop, Math.max(arr) is 10, Math.min(arr) is 10, so sum = 10 +10 + 10 which is 30.

You need to be summing all the numbers between 5 and 10 (inclusive) which would be 5 + 6 + 7 + 8 + 9 + 10 = 45

1 Like
``````
function sumAll(arr) {

var sum = 0;
var min = Math.min(arr);
var max = Math.max(arr);

for(var i = min; i <= max; i++){
sum += i;
}

return sum;
}

sumAll([1, 4]);
``````

this should work but it doesn’t

Math.min and Math.max accept arguments which need to be numbers. arr is an array, so since an array is not a number, each of the functions returns the value NaN. This causes the for loop to not execute the code inside, so sum remains 0.

I will give you two hints on how you can get the correct values of min and max.

1. One way would be to check if the first element of arr is greater than the second element of arr. If it is, assign max the value of the first element and min the value of the second element. Otherwise, the max should be assigned the value of the second element and min the value of the first element.

2. Another way is to look into how you could use the apply function with the Math.max and Math.mix functions to allow you to use arr’s elements as arguments/values for the functions.

1 Like

Thank you that works.

``````
function sumAll(arr) {

var sum = 0;
var min;
var max;

if(arr < arr){
min = arr;
max = arr;
}else{
min = arr;
max = arr;
}

for(var i = min; i <= max; i++){

sum += i;
}

return sum;
}

sumAll([1, 4]);

``````

Another way to write the above code is to assume the first element is the min and the second element is the max and only switch them if the first element is greater than the second element. This eliminates the need for the else statement.

``````min = arr;
max = arr;
if(arr > arr){
min = arr;
max = arr;
}
``````
1 Like

yeah that’s great How would you implement the above function so it accepts two arguments, rather then one? @RandellDawson

Just add a second parameter to the function declaration.

``````function sumAll(arr, secondArgument) {
``````

Hi, why is this code not running.
function sumAll(arr) {

var max = Math.max(arr);

var min = Math.min(arr);

var sum=0;

for(var i =min ; i<=max; i++ ) {

sum += i;

}

return sum;

}

you will need to tell also what is failing. What error do you get. What are the requirements?

In the future, please create your own topic when you have specific questions about your own challenge code. Only respond to another thread when you want to provide help to the original poster of the other thread or have follow up questions concerning other replies given to the original poster.

The easiest way to create a topic for help with your own solution is to click the Ask for Help button located on each challenge. This will automatically import your code in a readable format and pull in the challenge url while still allowing you to ask any question about the challenge or your code.

Thank you.