Hi everybody, as a lot of other folks I can’t pass test but code is working fine
CAn’t pass tests 8 and 13. Here the code
#!/bin/bash
PSQL="psql -X --username=freecodecamp --dbname=number_guess --tuples-only -c"
RANDOMICO=$((1 + $RANDOM % 1000))
echo $RANDOMICO
echo Enter your username:
read USERNAME
USERS=$($PSQL "SELECT name FROM users WHERE name='$USERNAME'")
if [[ -z $USERS ]]
then
echo Welcome, $USERNAME! It looks like this is your first time here.
else
N_GAMES=$($PSQL "SELECT COUNT(game_id) FROM games JOIN users ON games.user_id=users.user_id WHERE users.name='$USERNAME'")
N_GUESSES=$($PSQL "SELECT MIN(n_guesses) FROM games JOIN users ON games.user_id=users.user_id WHERE users.name='$USERNAME'")
echo "Welcome back,$USERS! You have played$N_GAMES games, and your best game took$N_GUESSES guesses." | xargs
fi
echo "Guess the secret number between 1 and 1000:"
read USERGUESS
ACTUAL_GUESSES=1
while [[ $USERGUESS != $RANDOMICO ]]
do
echo $ACTUAL_GUESSES
if [[ $USERGUESS =~ ^[0-9]+$ ]]
then
if [[ $USERGUESS < $RANDOMICO ]]
then
echo "It's higher than that, guess again:"
read USERGUESS
fi
if [[ $USERGUESS > $RANDOMICO ]]
then
echo "It's lower than that, guess again:"
read USERGUESS
fi
((ACTUAL_GUESSES++))
else
echo That is not an integer, guess again:
read USERGUESS
fi
done
echo "You guessed it in $ACTUAL_GUESSES tries. The secret number was $RANDOMICO. Nice job!"
And here the output
FAILED TEST LOG
✘ SUBTASKS 1.1 :8 Your script should print the correct welcome message for returning users
AssertionError [ERR_ASSERTION]: The expression evaluated to a falsy value:
assert(re.test(scriptOutput))
at Context.<anonymous> (test/1.1.test.js:98:5)
at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
✘ SUBTASKS 1.1 :13 Your script should print the correct message when a game is finished
AssertionError [ERR_ASSERTION]: The expression evaluated to a falsy value:
assert(re.test(scriptOutput))
at Context.<anonymous> (test/1.1.test.js:133:5)
at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
Ah sorry you meant the first of the screenshot, not of the test. Ok I will try to add something that adds the games to the database. But the task doesn’t mention doing it at all. It only mentions printing the game, and I do it in the script!
Are you sure that’s the problem?
yes… if user1234 play a game for the first time, the next time user1234 plays a game, the user should not be told that they are playing for the first time
I added what you said, but the same tasks keep failing.
#!/bin/bash
PSQL="psql -X --username=freecodecamp --dbname=number_guess --tuples-only -c"
RANDOMICO=$((1 + $RANDOM % 1000))
echo $RANDOMICO
echo Enter your username:
read USERNAME
USERS=$($PSQL "SELECT name FROM users WHERE name='$USERNAME'")
GAMER_ID=$($PSQL "SELECT user_id FROM users WHERE name='$USERNAME'")
if [[ -z $USERS ]]
then
echo Welcome, $USERNAME! It looks like this is your first time here.
INSERT1=$($PSQL "INSERT INTO users(name) VALUES ('$USERNAME')")
else
N_GAMES=$($PSQL "SELECT COUNT(game_id) FROM games WHERE user_id=$GAMER_ID")
N_GUESSES=$($PSQL "SELECT MIN(n_guesses) FROM games WHERE user_id=$GAMER_ID")
echo Welcome back, $USERS! You have played $N_GAMES games, and your best game took $N_GUESSES guesses. | xargs
fi
echo "Guess the secret number between 1 and 1000:"
read USERGUESS
ACTUAL_GUESSES=1
while [[ $USERGUESS != $RANDOMICO ]]
do
echo $ACTUAL_GUESSES
if [[ $USERGUESS =~ ^[0-9]+$ ]]
then
if [[ $USERGUESS < $RANDOMICO ]]
then
echo "It's higher than that, guess again:"
read USERGUESS
fi
if [[ $USERGUESS > $RANDOMICO ]]
then
echo "It's lower than that, guess again:"
read USERGUESS
fi
((ACTUAL_GUESSES++))
else
echo That is not an integer, guess again:
read USERGUESS
fi
done
INSERT2=$($PSQL "INSERT INTO games(user_id, n_guesses) VALUES ($GAMER_ID, $ACTUAL_GUESSES)")
echo You guessed it in $ACTUAL_GUESSES tries. The secret number was $RANDOMICO. Nice job!
the otput is
FAILED TEST LOG
✘ SUBTASKS 1.1 :8 Your script should print the correct welcome message for returning users
AssertionError [ERR_ASSERTION]: The expression evaluated to a falsy value:
assert(re.test(scriptOutput))
at Context.<anonymous> (test/1.1.test.js:98:5)
at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
✘ SUBTASKS 1.1 :13 Your script should print the correct message when a game is finished
AssertionError [ERR_ASSERTION]: The expression evaluated to a falsy value:
assert(re.test(scriptOutput))
at Context.<anonymous> (test/1.1.test.js:133:5)
at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
and the sql dump
--
-- PostgreSQL database dump
--
-- Dumped from database version 12.17 (Ubuntu 12.17-1.pgdg22.04+1)
-- Dumped by pg_dump version 12.17 (Ubuntu 12.17-1.pgdg22.04+1)
SET statement_timeout = 0;
SET lock_timeout = 0;
SET idle_in_transaction_session_timeout = 0;
SET client_encoding = 'UTF8';
SET standard_conforming_strings = on;
SELECT pg_catalog.set_config('search_path', '', false);
SET check_function_bodies = false;
SET xmloption = content;
SET client_min_messages = warning;
SET row_security = off;
DROP DATABASE number_guess;
--
-- Name: number_guess; Type: DATABASE; Schema: -; Owner: freecodecamp
--
CREATE DATABASE number_guess WITH TEMPLATE = template0 ENCODING = 'UTF8' LC_COLLATE = 'C.UTF-8' LC_CTYPE = 'C.UTF-8';
ALTER DATABASE number_guess OWNER TO freecodecamp;
\connect number_guess
SET statement_timeout = 0;
SET lock_timeout = 0;
SET idle_in_transaction_session_timeout = 0;
SET client_encoding = 'UTF8';
SET standard_conforming_strings = on;
SELECT pg_catalog.set_config('search_path', '', false);
SET check_function_bodies = false;
SET xmloption = content;
SET client_min_messages = warning;
SET row_security = off;
SET default_tablespace = '';
SET default_table_access_method = heap;
--
-- Name: games; Type: TABLE; Schema: public; Owner: freecodecamp
--
CREATE TABLE public.games (
game_id integer NOT NULL,
user_id integer,
n_guesses integer NOT NULL
);
ALTER TABLE public.games OWNER TO freecodecamp;
--
-- Name: games_game_id_seq; Type: SEQUENCE; Schema: public; Owner: freecodecamp
--
CREATE SEQUENCE public.games_game_id_seq
AS integer
START WITH 1
INCREMENT BY 1
NO MINVALUE
NO MAXVALUE
CACHE 1;
ALTER TABLE public.games_game_id_seq OWNER TO freecodecamp;
--
-- Name: games_game_id_seq; Type: SEQUENCE OWNED BY; Schema: public; Owner: freecodecamp
--
ALTER SEQUENCE public.games_game_id_seq OWNED BY public.games.game_id;
--
-- Name: users; Type: TABLE; Schema: public; Owner: freecodecamp
--
CREATE TABLE public.users (
user_id integer NOT NULL,
name character varying(25)
);
ALTER TABLE public.users OWNER TO freecodecamp;
--
-- Name: users_user_id_seq; Type: SEQUENCE; Schema: public; Owner: freecodecamp
--
CREATE SEQUENCE public.users_user_id_seq
AS integer
START WITH 1
INCREMENT BY 1
NO MINVALUE
NO MAXVALUE
CACHE 1;
ALTER TABLE public.users_user_id_seq OWNER TO freecodecamp;
--
-- Name: users_user_id_seq; Type: SEQUENCE OWNED BY; Schema: public; Owner: freecodecamp
--
ALTER SEQUENCE public.users_user_id_seq OWNED BY public.users.user_id;
--
-- Name: games game_id; Type: DEFAULT; Schema: public; Owner: freecodecamp
--
ALTER TABLE ONLY public.games ALTER COLUMN game_id SET DEFAULT nextval('public.games_game_id_seq'::regclass);
--
-- Name: users user_id; Type: DEFAULT; Schema: public; Owner: freecodecamp
--
ALTER TABLE ONLY public.users ALTER COLUMN user_id SET DEFAULT nextval('public.users_user_id_seq'::regclass);
--
-- Data for Name: games; Type: TABLE DATA; Schema: public; Owner: freecodecamp
--
INSERT INTO public.games VALUES (1, 1, 3);
--
-- Data for Name: users; Type: TABLE DATA; Schema: public; Owner: freecodecamp
--
INSERT INTO public.users VALUES (1, 'tony');
--
-- Name: games_game_id_seq; Type: SEQUENCE SET; Schema: public; Owner: freecodecamp
--
SELECT pg_catalog.setval('public.games_game_id_seq', 1, true);
--
-- Name: users_user_id_seq; Type: SEQUENCE SET; Schema: public; Owner: freecodecamp
--
SELECT pg_catalog.setval('public.users_user_id_seq', 1, true);
--
-- Name: games games_pkey; Type: CONSTRAINT; Schema: public; Owner: freecodecamp
--
ALTER TABLE ONLY public.games
ADD CONSTRAINT games_pkey PRIMARY KEY (game_id);
--
-- Name: users users_name_key; Type: CONSTRAINT; Schema: public; Owner: freecodecamp
--
ALTER TABLE ONLY public.users
ADD CONSTRAINT users_name_key UNIQUE (name);
--
-- Name: users users_pkey; Type: CONSTRAINT; Schema: public; Owner: freecodecamp
--
ALTER TABLE ONLY public.users
ADD CONSTRAINT users_pkey PRIMARY KEY (user_id);
--
-- Name: games games_user_id_fkey; Type: FK CONSTRAINT; Schema: public; Owner: freecodecamp
--
ALTER TABLE ONLY public.games
ADD CONSTRAINT games_user_id_fkey FOREIGN KEY (user_id) REFERENCES public.users(user_id);
--
-- PostgreSQL database dump complete
--
I did it in the end. But please, make it more clear that you need to write commands to add values that you put in the script to the database!!! It’s not clear at all
