Tic Tac Toe - Checking Win Condition

Hey folks,
I would greatly appreciate if someone could point out my stupidity here.
The code to check a win condition seems to run fine in repl.it but not in codepen.


If you check the console, it seems like the temp variable doesn’t populate in the function and I’m unable to understand why. I am sure I’m missing something.

Thanks in advance!

Hi @hxii

This is a perfect opportunity for you to learn how to debug a program.
Place the debugger statement before console.log("Loop " + i);
It should look like this:

 function checkOwin() { // Check if O wins
  for (i=0; i<winningConditions.length; i++) {
    console.log("Loop " + i);
    var temp = winningConditions[i].filter(function(n) {
      return oChecks.indexOf(n) !== -1;
    console.log("TEMP " + temp)
    if (temp.length >= 3) {
      console.log("WIN! " + winningConditions[i])

Then open the chrome dev tools and start playing.

Here are some helpful resources about debugging.

If you still won’t be able to figure out what’s broken after 15 mins, ping me and I’ll tell you.
It’s a simple mistake so I think you can do it on your own. GL & HF.


Thanks @marzelin!
Teach a man to fish, huh? :smiley:

I’ll admit it took me more than 15 minutes, but I finally figured it out: n.toString().
winningConditions contains numbers, while oChecks contains strings.

1 Like

I’d just like to add, in case someone stumbles across this searching for a similar problem:

The reason n.tostring() solves the problem is because the numbers I am pushing to the arrays are taken from the ID of the clicked element (id="1"), so they’re in fact strings, while the numbers in winningConditions are numbers.