Tribute page - Abebe Bikila

Code Feedback
1

Hey guys. I just finished my first project (the tribute page) and was wondering if anyone could give it a look and comment on it.
https://codepen.io/Bisrat-Aregawi/pen/gOaZbYp

2 Likes
2

Looking good @Bisrat-Aregawi,

I can see that you have all the tasks done. That’s what’s more important at the momento.

Something that it’s outside the scope of the assignment and competencies, you could add some line-height to your text.

Also, you can give your image a shadow, and some border radius to it.

Let me know if you need more help with that if you try it.

1 Like
3

Just made it better now. Thanks for the comments.

1 Like
4

Your page looks good @Bisrat-Aregawi. Some things to revisit;

  • In HTML, title is a reserved keyword and it goes in the head element, not anywhere in the body element. It’s what shows in the tab of the browser. It will never have a heading element.
    • If you want to include it in codepen, click on the ‘Settings’ button, then HTML and add it into the ‘Stuff for <head>’ box.
  • All of your styling should be external. Don’t use in-line styling.
    • And really there shouldn’t be a mix of the two.
  • The use of the figcaption element the way you have it is incorrect.
  • Review the lesson about giving meaningful text to links.

As an aside, you have a lot of links throughout your tribute. Wouldn’t all of those be answered if the user click his biography to learn more?

1 Like
5

Thanks for the heads up @Roma. I really appreciate it. Very technical. I have solved most of the errors you mentioned but about the number of links, I think wikipedia does this as well.