Tribute page—Feedback appreciated

Code Feedback
1

Hello! I just finished my tribute page and I would appreciate greatly some feedback. Also, I am wondering:

  • Is it okay to nest a flex container inside a grid container and vice versa?
  • Both Grid and flexbox seem kinda similar to one another. Is it a matter of preference or i should be using one over the other?

link: https://codepen.io/carvhal/pen/MWebzXj

thanks for your time!

2

Hey @carvhal!

I think your page looks good.

As for your questions about flexbox and grid, I found this great article that does a great job explaining the differences between the two.

Happy coding!

1 Like
3

Welcome to the forums @carvhal. Your page looks good. Some things to revisit;

  • Verify your email addr with codepen so we can see your page full view
  • Codepen provides the boilerplate for you. It only expects the code you’d put within the body element in HTML. (No need to include the body tags). For anything you want to add to the <head> element click on the ‘Settings’ button, then HTML and add it into the ‘Stuff for <head>’ box.

Some people usually use grid for the entire page-layout and flex for formatting rows and columns.
CSS Grid for 2-axis layout, Flexbox for single axis (either X or Y) layout, as a general rule of thumb.

1 Like
4

thanks @jwilkins.oboe and @Roma