Tribute Page feedback :-)

Code Feedback
1

Hi, I just completed my first assignment. Would love some feedback. Thanks!

A Pen by c-ehrlich (codepen.io)

2

Hey there, I think your tribute page looks awesome! My only comment is that the image looks a little small on mobile devices. Try using a media query to set the image’s width to a larger percentage if the screen is below a certain width. I also think it would look nice if you centred the title. Adding the CSS properties “text-align: center” and “margin: auto” should do the trick .

Keep up the good work. I hope you continue to pursue coding :slight_smile:

1 Like
3

Thanks for the feedback! I changed the #img-div to be 95% wide at under 500px, which I think should cover just about every phone?

4

Welcome to the forums @cehrlich. Your page looks good. Some things to revisit;

  • Codepen provides the boilerplate for you. It only expects the code you’d put within the body element in the HTML editor. (No need to include the body tags). For anything you want to add to the <head> element click on the ‘Settings’ button, then HTML and add it into the ‘Stuff for <head>’ box.
    • For instance links to fonts go in the box labeled ‘Stuff for <head>’
    • You also have elements placed incorrectly. Review this for an understanding of the HTML boilerplate tags.
  • Run your HTML code through the W3C validator.
    • There is an HTML syntax/coding error you should be aware of and address. (One of your ul elements is nested incorrectly)
  • Use external styling. Do not use internal (or in-line) styling.
  • Accessibility is about being accessible to all users. Review the giving meaningful text to links lesson. For a more thorough explanation read Web Accessibility in Mind.
    • “wikipedia entry” is not accessible
  • Use the DRY (Don’t Repeat Yourself) principle.
    • the font-family and color are the same for h1 and h2, as well as p and ul are styled the same.
1 Like
5

Thanks for the feedback!

One question regarding your last point: if h1 and h2 have the same font-family and color but h1 has some additional properties, would something like this be a better implementation?

h1, h2 { <!--shared properties--> }
#extra-stuff-for-h1 { <!--h1 properties--> }

<h1 id="extra-stuff-for-h1">Heading 1</h1>
<h2>Heading 2</h2>

And in general, is there a good resource to learn about some best practices on this?

6

Yes, that would be better. Easier to maintain.
Other than remembering the DRY principle it’s just something that will come over time or from having your code peer reviewed and having it pointed out to you.

1 Like
7

This topic was automatically closed 182 days after the last reply. New replies are no longer allowed.