Tribute Page - Nikola Tesla Again

Code Feedback
1

Hi I have build the page similar to the exercise.
Can you comment out what should I be improving on.

https://codepen.io/tviveksingh30/pen/qzmPqV

thanks in advance.

1 Like
2

Looks pretty good, there isn’t much to comment on.

  1. On the body you are setting padding-top: 20px but then overwriting it later by setting padding: 10px. I would just keep the top padding and also remove the default margin from the body.

  2. You might try using the vw unit for the width on #main instead of %, that way it will adapt to the screen size. You can also do that for the padding on #tribute-info

  3. Another option is to give the #tribute-info content a container and setting a max-width on it. This will let you control the paragraph length a bit better.

<section id="tribute-info">
  <div class="container">
  ...content
  </div>
</section>

.container {
  max-width: 720px;
  margin: auto;
}
  1. I would move the inline CSS from the footer paragraph to the CSS.

Good job.

2 Likes
3

Thanks. I will work on it.