Tribute Page Project -- Eddie Van Halen

Code Feedback
1

I just finished the Tribute Page Project

Please take a look and let me know if I made any crazy mistakes or areas that need improvement

I know I was crazy for wanting to place (and keep the text in place when resizing) over the image, but I found myself wanting to make it work even though it was a pain.

Thanks

1 Like
2

Hey @breadedfish!

I think your page looks great. One thing that I noticed was this.

link?
link?1266Ă—212 22.2 KB

The link isn’t that obvious to click on . So maybe choose a different color so the user knows that it is a link.

Hope that helps!

Happy coding!

3

Great job for first project! Really like the text over image, even if it was a pain (get used to that feeling :joy:)

4

Hey @breadedfish. Great job! I like the way you put the text besides the image. Wonderful! But, I mind if I give some suggestions?:

  • Don’t use @import CSS rules to import Google Fonts. Using @import will slow down your project. When you want to import Google Fonts, do the following:

    • First remove the @import statements.
    • Next go to Google Fonts and pick your fonts.
    • Click on the “Embed” tab on the left sidebar.
    • Copy the code provided and go to CodePen.
    • Click on the settings icon at the top of HTML box.
    • Paste your code in the "Stuff for <head>" box.

Screenshot 2020-10-15 132215
Screenshot 2020-10-15 1322152029Ă—862 151 KB

  • Why did you use @charset rule in CSS? I think that is unnecessary.

Anyway, impressive work and I like it. Thumbs up! :+1:t2:

5

thanks, I went ahead and updated it

1 Like
6

Oh! I’ve never used codepen before, I used @import because I just assumed there was no option to put code into the head tags thanks!.

I use adobe dreamweaver, when you create a new html file it puts <meta charset="utf-8"> in the file. Then if you use it to generate a css file it will automatically put the @charset in. I did a little digging at stackoverflow claims that it saves the browser the time to declare what charset to set, so I see no harm in leaving it in?

2 Likes
7

Hello @breadedfish,

If there is no problem with that, then you are free to use it.