Tribute Page to The Father of Algebra

Code Feedback
1

Hi campers,

I’ve already done my Tribute Page project, I hope you guys can give me some feedback :smiley:

Thank you

Tribute Page - The Father of Algebra

2

Your website is not very mobile friendly

Screenshot_20200911-081903
Screenshot_20200911-0819031440×2960 426 KB

1 Like
3

Thanks for the feedback Jeremy.

Looks like it’s because I’m just focusing to the user story. Although for me it’s still not easy to make it mobile friendly but I’ll try to do it :smiley:

1 Like
4

Your page looks good @dwisatriow. Some things to revisit;

  • Keep the test script when forking the pen (<script src="https://cdn.freecodecamp.org/testable-projects-fcc/v1/bundle.js"></script>).
    • The test script should be included, with all tests passing, when you submit your projects.
  • Codepen provides the boilerplate for you. It only expects the code you’d put within the body element in HTML. (No need to include the body tags). For anything you want to add to the <head> element click on the ‘Settings’ button, then HTML and add it into the ‘Stuff for <head>’ box.
    • The link to the font goes in the box labeled ‘Stuff for <head>’
  • Run your HTML code through the W3C validator.
    • There are HTML coding errors you should be aware of and address.
    • Since copy/paste from codepen you can ignore the first warning and first two errors.
  • Don’t use the <br> element to force line breaks or spacing. That’s what CSS is for.
  • Review the lesson about giving meaningful text to links.
  • Your page needs to be responsive.
    • Remember, the R in RWD stands for Responsive
    • You’ve hardcoded widths as pixels. Your page would be more responsive if those were percentages instead.
1 Like
5

Thanks for your feedback @Roma.

A lot of things to do there, but I will try to learn and check them out also refactor the code as you suggested :smiley:

Thank you :smiley:

6

Wow, it looks great! Amazing first project!

1 Like