Budget App chart output seems correct but there is an error

[pavlokonstantinov25]

This is my code but there is an error.
create_spend_chart should print a different chart representation. Check that all spacing is exact.
How to fix it?

class Category:
    def __init__(self, category):
        self.category = category
        self.ledger = []

    def deposit(self, amount, description=""):
        self.ledger.append({"amount": amount, "description": description})

    def withdraw(self, amount, description=""):
        if self.check_funds(amount):
            self.ledger.append({"amount": -amount, "description": description})
            return True
        return False

    def get_balance(self):
        return sum(item["amount"] for item in self.ledger)

    def transfer(self, amount, budget_category):
        if self.check_funds(amount):
            self.withdraw(amount, f"Transfer to {budget_category.category}")
            budget_category.deposit(amount, f"Transfer from {self.category}")
            return True
        return False

    def check_funds(self, amount):
        return self.get_balance() >= amount

    def __str__(self):
        title = f"{self.category:*^30}\n"
        items = ""
        for item in self.ledger:
            items += f"{item['description'][:23]:23}{item['amount']:>7.2f}\n"
        total = f"Total: {self.get_balance():.2f}"
        return title + items + total


def create_spend_chart(categories):
    chart = "Percentage spent by category\n"

    # Calculate the percentage spent for each category
    spendings = [sum(item["amount"] for item in category.ledger if item["amount"] < 0) for category in categories]
    total_spent = sum(spendings)
    percentages = [int(spending / total_spent * 100) for spending in spendings]

    # Build the chart row by row
    for i in range(100, -1, -10):
        chart += str(i).rjust(3) + "| "
        for percentage in percentages:
            chart += "o" if percentage >= i else " "
            chart += "  "
        chart += "\n"

    # Add the bottom line
    chart += "    -" + "---" * len(categories) + "\n"

    # Find the maximum category name length
    max_name_length = max(len(category.category) for category in categories)

    # Build the category names row by row
    for i in range(max_name_length):
        chart += "     "
        for category in categories:
            if i < len(category.category):
                chart += category.category[i] + "  "
            else:
                chart += "   "
        chart += "\n"

    return chart.rstrip()

# Example usage
food = Category("Food")
food.deposit(1000, "deposit")
food.withdraw(10.15, "groceries")
food.withdraw(15.89, "restaurant and more food for dessert")

clothing = Category("Clothing")
food.transfer(250, clothing)
clothing.deposit(1000, "deposit")
clothing.transfer(100, food)

print(create_spend_chart([food, clothing]))

https://www.freecodecamp.org/learn/scientific-computing-with-python/scientific-computing-with-python-projects/budget-app

[pkdvalis]

Have a look at this thread:
https://forum.freecodecamp.org/t/scientific-computing-with-python-projects-budget-app/677914

Here is the expected output that you need to match:

Percentage spent by category\n100|          \n 90|          \n 80|          \n 70|    o     \n 60|    o     \n 50|    o     \n 40|    o     \n 30|    o     \n 20|    o  o  \n 10|    o  o  \n  0| o  o  o  \n    ----------\n     B  F  E  \n     u  o  n  \n     s  o  t  \n     i  d  e  \n     n     r  \n     e     t  \n     s     a  \n     s     i  \n           n  \n           m  \n           e  \n           n  \n           t

And here is the test data:

food = Category("Food")
entertainment = Category("Entertainment")
business = Category("Business")    
food.deposit(900, "deposit")
entertainment.deposit(900, "deposit")
business.deposit(900, "deposit")

food.withdraw(105.55)
entertainment.withdraw(33.40)
business.withdraw(10.99)

print(repr(create_spend_chart([business, food, entertainment]))

You can use repr() to print at the end to show raw string output

You can also read through this thread:
https://forum.freecodecamp.org/t/scientific-computing-with-python-projects-budget-app/677107

[pavlokonstantinov25]

Percentage spent by category\n100|          \n 90|          \n 80|          \n 70|    o     \n 60|    o     \n 50|    o     \n 40|    o     \n 30|    o     \n 20|    o  o  \n 10|    o  o  \n  0| o  o  o  \n    ----------\n     B  F  E  \n     u  o  n  \n     s  o  t  \n     i  d  e  \n     n     r  \n     e     t  \n     s     a  \n     s     i  \n           n  \n           m  \n           e  \n           n  \n           t

Results are same but I can’t pass this test.

[pkdvalis]

I’ve edited your code for readability. When you enter a code block into a forum post, please precede it with a separate line of three backticks and follow it with a separate line of three backticks to make it easier to read.

You can also use the “preformatted text” tool in the editor (</>) to add backticks around text.

See this post to find the backtick on your keyboard.
Note: Backticks (`) are not single quotes (').

[pavlokonstantinov25]

This is my code…

class Category:
    def __init__(self, category):
        self.category = category
        self.ledger = []

    def deposit(self, amount, description=""):
        self.ledger.append({"amount": amount, "description": description})

    def withdraw(self, amount, description=""):
        if self.check_funds(amount):
            self.ledger.append({"amount": -amount, "description": description})
            return True
        return False

    def get_balance(self):
        return sum(item["amount"] for item in self.ledger)

    def transfer(self, amount, budget_category):
        if self.check_funds(amount):
            self.withdraw(amount, f"Transfer to {budget_category.category}")
            budget_category.deposit(amount, f"Transfer from {self.category}")
            return True
        return False

    def check_funds(self, amount):
        return self.get_balance() >= amount

    def __str__(self):
        title = f"{self.category:*^30}\n"
        items = ""
        for item in self.ledger:
            items += f"{item['description'][:23]:23}{item['amount']:>7.2f}\n"
        total = f"Total: {self.get_balance():.2f}"
        return title + items + total


def create_spend_chart(categories):
    chart = "Percentage spent by category\n"

    # Calculate the percentage spent for each category
    spendings = [sum(item["amount"] for item in category.ledger if item["amount"] < 0) for category in categories]
    total_spent = sum(spendings)
    percentages = [int(spending / total_spent * 100) for spending in spendings]

    # Build the chart row by row
    for i in range(100, -1, -10):
        chart += str(i).rjust(3) + "| "
        for percentage in percentages:
            chart += "o  " if percentage >= i else "   "
        chart += "\n"

    # Add the bottom line
    chart += "    -" + "---" * len(categories) + "\n"

    # Find the maximum category name length
    max_name_length = max(len(category.category) for category in categories)

    # Build the category names row by row
    for i in range(max_name_length):
        chart += "    "
        for category in categories:
            if i < len(category.category):
                chart += " " + category.category[i] + " "
            else:
                chart += "   "
        chart += "\n"

    return chart.rstrip()

# Example usage
food = Category("Food")
entertainment = Category("Entertainment")
business = Category("Business")    
food.deposit(900, "deposit")
entertainment.deposit(900, "deposit")
business.deposit(900, "deposit")

food.withdraw(105.55)
entertainment.withdraw(33.40)
business.withdraw(10.99)

print(create_spend_chart([business, food, entertainment]))```

[pkdvalis]

Confirmed, it does match exactly.

Not sure what happened but it looks like there now needs to be two extra spaces at the end. Here is the expected output (I added single quotes so you can see the two spaces at the end):

'Percentage spent by category\n100|          \n 90|          \n 80|          \n 70|    o     \n 60|    o     \n 50|    o     \n 40|    o     \n 30|    o     \n 20|    o  o  \n 10|    o  o  \n  0| o  o  o  \n    ----------\n     B  F  E  \n     u  o  n  \n     s  o  t  \n     i  d  e  \n     n     r  \n     e     t  \n     s     a  \n     s     i  \n           n  \n           m  \n           e  \n           n  \n           t  '

Maybe it changed or maybe I didn’t copy it correctly in the first place…

[pavlokonstantinov25]

‘Percentage spent by category\n100| \n 90| \n 80| \n 70| o \n 60| o \n 50| o \n 40| o \n 30| o \n 20| o o \n 10| o o \n 0| o o o \n ----------\n B F E \n u o n \n s o t \n i d e \n n r \n e t \n s a \n s i \n n \n m \n e \n n \n t’

I think it match exactly,

[pkdvalis]

You need 2 more spaces after the final t

[pavlokonstantinov25]

Make sense, I will try again.

[pavlokonstantinov25]

I added two spaces after final t, but still can’t pass this.

[pkdvalis]

The rstrip in the return will remove them again.

You’re almost there!

[pavlokonstantinov25]

You are right, if I use rstrip, it remove them again.
That’s why and how can I pass it?

[pkdvalis]

You could add them after the rstrip… it’s not an ideal solution since that won’t really work for every case but…

The idea is that the spaces should form a grid like this:

[pkdvalis]

You can see this is missing two spaces after the final 't' to form that grid:

[pavlokonstantinov25]

Understand.
I am trying to fix it, but not doing well…

[pavlokonstantinov25]

I replace chart += "\n" to chart += " \n".
And also I used ‘*’ instead space, after then I can see correct result.
But I can’t still pass this test.

[pkdvalis]

This looks good, but when you go back to spaces the rstrip will remove the last spaces again.

(Will also need to watch out for a trailing \n)

[pavlokonstantinov25]

If rstrip() is not used, it returns a space and ‘\n’.
But still error …

[pkdvalis]

You can add some logic that says

If this is not the last line,
    add `\n`
but if this is the last line, 
   don't add `\n`, add a space, or whatever you need

You could also be calculating how many characters wide each line will be and dynamically add spaces that way