Build a Medical Data Validator - Step 44

Tell us what’s happening:

Please, I am stuck. I don’t understand why it’s not working.

Your code so far

import re


medical_records = [
    {
        'patient_id': 'P1001',
        'age': 34,
        'gender': 'Female',
        'diagnosis': 'Hypertension',
        'medications': ['Lisinopril'],
        'last_visit_id': 'V2301',
    },
    {
        'patient_id': 'p1002',
        'age': 47,
        'gender': 'male',
        'diagnosis': 'Type 2 Diabetes',
        'medications': ['Metformin', 'Insulin'],
        'last_visit_id': 'v2302',
    },
    {
        'patient_id': 'P1003',
        'age': 29,
        'gender': 'female',
        'diagnosis': 'Asthma',
        'medications': ['Albuterol'],
        'last_visit_id': 'v2303',
    },
    {
        'patient_id': 'p1004',
        'age': 56,
        'gender': 'Male',
        'diagnosis': 'Chronic Back Pain',
        'medications': ['Ibuprofen', 'Physical Therapy'],
        'last_visit_id': 'V2304',
    }
]


def find_invalid_records(
    patient_id, age, gender, diagnosis, medications, last_visit_id
):

    constraints = {
        'patient_id': isinstance(patient_id, str)
        and re.fullmatch('p\d+', patient_id, re.IGNORECASE),
        'age': isinstance(age, int) and age >= 18,
        'gender': isinstance(gender, str) and gender.lower() in ('male', 'female'),
        'diagnosis': isinstance(diagnosis, str) or diagnosis is None,
        'medications': isinstance(medications, list)
        and all([isinstance(i, str) for i in medications]),
        'last_visit_id': isinstance(last_visit_id, str)
        and re.fullmatch('v\d+', last_visit_id, re.IGNORECASE)
    }

    return [key for key, value in constraints.items() if not value]


def validate(data):
    is_sequence = isinstance(data, (list, tuple))

    if not is_sequence:
        print('Invalid format: expected a list or tuple.')
        return False
        
    is_invalid = False
    key_set = set(
        ['patient_id', 'age', 'gender', 'diagnosis', 'medications', 'last_visit_id']
    )

    for index, dictionary in enumerate(data):
        if not isinstance(dictionary, dict):
            print(f'Invalid format: expected a dictionary at position {index}.')
            is_invalid = True
            continue

        if set(dictionary.keys()) != key_set:
            print(
                f'Invalid format: {dictionary} at position {index} has missing and/or invalid keys.'
            )
            is_invalid = True
            continue

        invalid_records = find_invalid_records(**dictionary)

# User Editable Region

        for index, (key, val) in enumerate(invalid_records):
            print(f"Unexpected format '{key}: {val}' at position {index}.")
            is_invalid = True


# User Editable Region

    if is_invalid:
        return False
    print('Valid format.')
    return True

validate(medical_records)

Your browser information:

User Agent is: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/142.0.0.0 Safari/537.36

Challenge Information:

Build a Medical Data Validator - Step 44

What does the error message say?

Where did you get stuck debugging?

The error message is saying - You should have a for loop that iterates over invalid_records

Ok, and where did you get stuck debugging?


I suspect the step wants you to iterate over invalid_records and not enumerate(invalid_records)

I’m stuck on how to create a for loop to iterate over invalid-records

so iterate on invalid_records instead of on enumare(invalid_records)

You seem to be missing the second half of my messages?

1 Like

I’ve done that, but it’s showing – You should print Unexpected format '<key>: <val>' at position <index>. (where <key>, <val>, and <index> should be replaced by the current key, value and index) inside your for loop.
I’m confused, please help.

What is your updated code?

Please post your code instead of a picture.

I don’t think that is a valid set of items in invalid_records. It is only a single list

import re




medical_records = \[

    {

        'patient_id': 'P1001',

        'age': 34,

        'gender': 'Female',

        'diagnosis': 'Hypertension',

        'medications': \['Lisinopril'\],

        'last_visit_id': 'V2301',

    },

    {

        'patient_id': 'p1002',

        'age': 47,

        'gender': 'male',

        'diagnosis': 'Type 2 Diabetes',

        'medications': \['Metformin', 'Insulin'\],

        'last_visit_id': 'v2302',

    },

    {

        'patient_id': 'P1003',

        'age': 29,

        'gender': 'female',

        'diagnosis': 'Asthma',

        'medications': \['Albuterol'\],

        'last_visit_id': 'v2303',

    },

    {

        'patient_id': 'p1004',

        'age': 56,

        'gender': 'Male',

        'diagnosis': 'Chronic Back Pain',

        'medications': \['Ibuprofen', 'Physical Therapy'\],

        'last_visit_id': 'V2304',

    }

\]




def find_invalid_records(

    patient_id, age, gender, diagnosis, medications, last_visit_id

):



    constraints = {

        'patient_id': isinstance(patient_id, str)

        and re.fullmatch('p\\d+', patient_id, re.IGNORECASE),

        'age': isinstance(age, int) and age >= 18,

        'gender': isinstance(gender, str) and gender.lower() in ('male', 'female'),

        'diagnosis': isinstance(diagnosis, str) or diagnosis is None,

        'medications': isinstance(medications, list)

        and all(\[isinstance(i, str) for i in medications\]),

        'last_visit_id': isinstance(last_visit_id, str)

        and re.fullmatch('v\\d+', last_visit_id, re.IGNORECASE)

    }



    return \[key for key, value in constraints.items() if not value\]




def validate(data):

    is_sequence = isinstance(data, (list, tuple))



    if not is_sequence:

        print('Invalid format: expected a list or tuple.')

        return False

        

    is_invalid = False

    key_set = set(

        \['patient_id', 'age', 'gender', 'diagnosis', 'medications', 'last_visit_id'\]

    )



    for index, dictionary in enumerate(data):

        if not isinstance(dictionary, dict):

            print(f'Invalid format: expected a dictionary at position {index}.')

            is_invalid = True

            continue



        if set(dictionary.keys()) != key_set:

            print(

                f'Invalid format: {dictionary} at position {index} has missing and/or invalid keys.'

            )

            is_invalid = True

            continue



        invalid_records = find_invalid_records(\*\*dictionary)

        for key, val in invalid_records:

            print(f"Unexpected format '{key}: {val}' at position {index}.")

            is_invalid = True



    if is_invalid:

        return False

    print('Valid format.')

    return True



validate(medical_records)

I’ve edited your post to improve the readability of the code. When you enter a code block into a forum post, please precede it with three backticks to make it easier to read.

You can also use the “preformatted text” tool in the editor (</>) to add the backticks.

See this post to find the backtick on your keyboard.
Note: Backticks (`) are not single quotes (').

I still think invalid_records is a list of single items?

This is what is returned and set as the invalid_records

import re


medical_records = [
    {
        'patient_id': 'P1001',
        'age': 34,
        'gender': 'Female',
        'diagnosis': 'Hypertension',
        'medications': ['Lisinopril'],
        'last_visit_id': 'V2301',
    },
    {
        'patient_id': 'p1002',
        'age': 47,
        'gender': 'male',
        'diagnosis': 'Type 2 Diabetes',
        'medications': ['Metformin', 'Insulin'],
        'last_visit_id': 'v2302',
    },
    {
        'patient_id': 'P1003',
        'age': 29,
        'gender': 'female',
        'diagnosis': 'Asthma',
        'medications': ['Albuterol'],
        'last_visit_id': 'v2303',
    },
    {
        'patient_id': 'p1004',
        'age': 56,
        'gender': 'Male',
        'diagnosis': 'Chronic Back Pain',
        'medications': ['Ibuprofen', 'Physical Therapy'],
        'last_visit_id': 'V2304',
    }
]


def find_invalid_records(
    patient_id, age, gender, diagnosis, medications, last_visit_id
):

    constraints = {
        'patient_id': isinstance(patient_id, str)
        and re.fullmatch('p\d+', patient_id, re.IGNORECASE),
        'age': isinstance(age, int) and age >= 18,
        'gender': isinstance(gender, str) and gender.lower() in ('male', 'female'),
        'diagnosis': isinstance(diagnosis, str) or diagnosis is None,
        'medications': isinstance(medications, list)
        and all([isinstance(i, str) for i in medications]),
        'last_visit_id': isinstance(last_visit_id, str)
        and re.fullmatch('v\d+', last_visit_id, re.IGNORECASE)
    }

    return [key for key, value in constraints.items() if not value]


def validate(data):
    is_sequence = isinstance(data, (list, tuple))

    if not is_sequence:
        print('Invalid format: expected a list or tuple.')
        return False
        
    is_invalid = False
    key_set = set(
        ['patient_id', 'age', 'gender', 'diagnosis', 'medications', 'last_visit_id']
    )

    for index, dictionary in enumerate(data):
        if not isinstance(dictionary, dict):
            print(f'Invalid format: expected a dictionary at position {index}.')
            is_invalid = True
            continue

        if set(dictionary.keys()) != key_set:
            print(
                f'Invalid format: {dictionary} at position {index} has missing and/or invalid keys.'
            )
            is_invalid = True
            continue

        invalid_records = find_invalid_records(**dictionary)
        for key in invalid_records:
            val = dictionary[key]
            print(f"Unexpected format '{key}: {val}' at position {index}.")
            is_invalid = True

    if is_invalid:
        return False
    print('Valid format.')
    return True

validate(medical_records)