Can you please feedback about my project?

Code Feedback
#1

Hi everyone, i would be so glad to see your feedback about my project.

I want to improve myself , so i need some suggestions.

Thank you in advance .

1 Like
#2

Hi !

The video looks broken arg !

:slight_smile:

#3

I didn’t want to link a specific video so i just linked to youtube.
I have no idea why it doesn’t show the youtube. :slight_smile:

#4

You could play with list/bullet design or with space between offers boxes or level up your input design part or try to insert your logo into the navbar…or do the all fully mobile responsive or something like that :slight_smile:

1 Like
#5

Hello Dashi,

Really cool, simple and clean project :slight_smile:
The only thing that I see wrong is:
-Video not working
-There is a small line between the header and the top navbar, don’t know if this was on purpose or not.

But rather than that, uau, really cool!
Love the shade of the navbar!

#6

Hi, it looks very clean. And the hero part looks really interesting.

  • Unfortunately it doesn’t work good on smaller devices. When the screen is smaller than 615px the text is cut on the left and right.
  • It would look better if the price cards were the equal width, and still on smaller devices they should go one below another, they shouldn’t be fixed one next to another. If you are using flex you can add flex-wrap: wrap, but then you have to work on the width and height of your price boxes.
#7

Your page looks good @Dashi. Some things to revisit;

  • Keep the test script when forking the pen (<script src="https://cdn.freecodecamp.org/testable-projects-fcc/v1/bundle.js"></script>).
    • Your page passes 10/16 user stories.
    • The test script should be included, with all tests passing, when you submit your projects.
  • When using codepen it only expects the code you’d put within the <body> </body> element in HTML. (No need to include the body tags). For anything you want to add to <head> click on the ‘Settings’ button, then HTML and add it into the ‘Stuff for <head>’ box.
    • Everything in the body element is what gets rendered by the browser. You have elements outside of the opening body tag that should be inside it. Since codepen provides the boilerplate for you, just get rid of the html and body tags.
  • One of the user stories is to provide an embedded product video so you do need to link to a specific video.
#8

That gave ma so much help thank you so much i never knew about this . Now i can complate easyly my projects and see what is wrong.

#9

Thanks a lot , ill work on them.

#10

I just realized that and my navigation bar does not work top of the page . I will fix it . Thank you for your feedback . :slight_smile:

#11

I think page passes test now and hope design looks better :slight_smile:

1 Like
#12

Your project really looks, great man. The color scheme is unique and unparalleled.
One thing you can do is add a smooth scroll.

HTML, body{ 
scroll-behaviour: smooth; 
}

This will give a good effect to your page.

I’ve also just completed this project few days ago - Feedback is appreciated.
click here

#13

Hey congrats !

Testing is all right but what about you ? What is your feeling ?
Do you want to add something or change something ? or learn something new to modify something ? or maybe do you want to try something else ?

Have a nice day :slight_smile:

#14