Choropleth Project FeedBack

Code Feedback
1

Hello! I just noticed that there is a Code feedback topic and I love that. I would like any criticisms people might have. I know that to get better I need to fail and I also need outside opinions, so if you spend the time to look through the project Thank you from the bottom of my heart.

repository can be found here:

Choropleth Project Working Link:

2

Looking good :+1: Easy to see where the “hot” points are.

I notice you are loading unemployment data, which I believe you don’t really use in your map? Were you planning to add this? Could be an interesting correlation.

I think it’s always important for graphs like this to cite the data source. (To verify and find out exactly what’s being plotted)

Outlining each state is a very nice touch :+1:

I like your use of await it seems a lot more straightforward than what I did:

d3.json('counties.json').then((countiesData) => {
  d3.json(
    'education.json'
  ).then((educationData) =>
    chartme(countiesData, educationData)
  );
});

Similar result but mine was too complicated just to load 2 data sources!

Here is mine for comparison: https://vizhub.com/pkdvalis/660c94b6817144a39cc8fb771b23a4ab

1 Like
3

Welcome to the forum @amcli8079

For the legend I noticed it goes from 0% to 100%.
Another option is to display the range from minimum to maximum percentages.

Happy coding

1 Like
4

Oh yeah I was a little silly and was finding my own open source api’s before I saw that there were data sets already given. Thanks for the reminder

5

Thank you for your time. I did do something similar in other legends and struggled a lot with this ones implementation here to make it look good. I’m pretty sure at the time I didn’t understand the relationship of domains and ranges (along with it getting more complicated when you need to figure out what scale to use). I know MORE now on legend creation so I think I’ve improved after struggling so much with this one, haha.

Again thanks for the look, and I’ll keep that in mind to make it more responsive to many data sets. I want to go back to this to set up a changing map based on different, but similar, data in the US counties.

1 Like