Dian Fossey Tribute Page

Code Feedback
#1

Hi everyone,

I would appreciate some feedback on my tribute page please, she says nervously.

https://codepen.io/Olittlun/pen/abONWLe?editors=1100

I am very new to this so any helpful advice would be very welcome.

Thank you :smile:

3 Likes
#2

Welcome to the forums @Olittlun. Your page looks good but there is something you need to revisit.

  • Do not use <br> to force line breaks or spacing. If you want to add space you can do that with margin and/or padding in CSS.
    • In this case, you wanted six paragraphs. Then have six paragraph elements <p>Content of the paragraph element</p>
  • You never closed this <div id="img-div">
#3

Hi @Roma,

Thank you for your advice. I did think the <br> was the wrong way to go. I have changed to <p> now and actually the spacing stayed the same without doing any padding which was surprising. Should I put some in anyway?

Thanks

Michaela

#4

Hi @Olittlun. Did you create a new pen? Or not save your changes? I’m still seeing the <br> tags.
I don’t think you need to add any additional padding. Paragraph tags separate nicely.

#5

Hi @Roma ,

I forgot to save it, silly me. Should be ok now.

Thanks

Michaela

#6

Hi @Roma again,

I was just wondering if you could take a look at my survey form as well and give me your feedback.

https://codepen.io/Olittlun/pen/MWwNKjr

Many Thanks

Michaela :smile:

#7

Both look good @Olittlun. Nice job! Keep on going.

#8