Documentation Page - Please, give me feedback on my 4th ever page

Code Feedback
1

Hello guys,

I have done the 4th project now and would like to receive any feedback. Positive and negative welcome. What to improve, what is wrong, what should I stick to etc.

Here is the link:

https://codepen.io/TomasJevcik/pen/MdNMjR

Thanks in advance.

2

It looks pretty good.

  1. You should remove the float on the #navbar when you stack the page, otherwise, you have to give it a z-index to make the links clickable. Just set the float to none in the media query you have.

  2. Not sure if it is intended that the nav is not the full height of the page (if not just add height: 100%; to it) but I actually kind of like the look it gives. I’m just not sure it’s height should be so arbitrary may be set a height less than 100% so you have a rule for how tall it should be. That will also let you remove the invalid <br> elements (The <br> element cannot be a child of the <ul> element.)

3

Since this is not really a Technical Documentation page I guess I shouldn’t find it odd that to pass the tests you actually did this;

<code></code>
<code></code> 
<code></code>
<code></code>
<code></code>

:unamused:

Too, codepen provides validators for HTML, CSS and JS. Click on the arrow and then click on the respective ‘Analyze’ link. In HTML you have errors;

  • <br> cannot be a child of the <ul> element

None of your navbar links work on smaller screens