FCC - Survey Form -

Code Feedback
1

Please check out my survey form.
https://codepen.io/smartray/full/YzXOvpG
Any and all feedback will be appreciated.
Thanks.

2

Great work! Although a little painful in the eyes for someone who’s sensitive to light like me or I guess I’m just a night owl.

For the forms, try reducing the width of your input elements.

1 Like
3

Thanks. I have adjusted the width of the input elements. Would go easy on the colors next time.

4

Your form looks okay @smartray. Some things to revisit;

  • On using codepen. codepen only expects the code you’d put within the <body> </body> tags in HTML. (No need to include the body tags). For anything you want to add to <head> click on the ‘Settings’ button, then HTML and add it into the ‘Stuff for <head>’ box.
    • The link to your font would go in the box labeled ‘Stuff for <head>’
    • The FCC test script is JavaScript. It would not go into the head
  • Run your HTML code through the W3C validator. Just copy your HTML and paste it into the ‘Validate by Direct Input’ tab.
    • There are quite a few errors that need to be cleaned up.
    • An id should be unique for the document
  • Do not use internal and in-line styling. All your styling should be external.
  • Users should be able to click on the label to select the option. Not just the checkbox.
    • Review the lesson on properly nesting radio buttons within the label element. And when you fix that apply it to the checkboxes as well.
  • Do not use the <br> element to force line breaks or spacing. Use margin and/or padding in CSS.
  • Make the submit button look like a button instead of a bar
5

Thanks a lot for the in depth feedback, it really means a lot to me, i will effect the changes to the various pen i have created. i would also love for you to check this one out i tried to implement some of the things you pointed out. would also appreciate a feedback to enable me improve which is what i want.
https://codepen.io/smartray/full/NWqoLJK

6

Wow! Impressive work!

I would suggest that you add a little box-shadow for each separate form window/section.
Maybe darken the background by just a little or something that makes it not so painful on the eyes.

Usually, a submit button is not gradiented. It’s best to keep it a solid color.
Plus, the submit button is not submitting. Please fix that.

At all else, great job. Keep up the great work!