FCC: Tribute to Stan Lee

HTML-CSS
1

Just finished my tribute page and would like to get any insight on the code - ways to minimize writing or better grouping for better readability. Any and all comments are welcome.

[FCC: Tribute Page] (https://codepen.io/drosenberger/pen/KbzJvL)

2

I think the captions is missing. I see a css IMS caption transparent, not sure it will pass without a caption. Try google html caption. There is a w3 school that will give you the tag to use.

I think your main I’d has a text-align center. This is a parent to your paragraph. I’m not sure if you want your paragraphs centered.

I’m on a phone so please ignore my type o’s.

3

@helen1 It actually does pass all test. And no I didn’t want the paragraph centered, thank you for point it out to me.

1 Like
4

Looks good.

  1. I would work a little with the legibility of the tribute info.

Here is a quick take on it:

#tribute-info {
  /* margin auto to center, because of the max-width */
  margin: 20px auto;
  /* Match the space given to top/bottom and sides */
  padding: 30px 54px;
  /* Less transparent background */
  background-color: #e4e4e4eb;
  color: #292929;
  font-size: 24px;
  /* Give a max-width so the eyes doesn't have to travel so far when reading */
  max-width: 1080px;
  /* justify or don't i think it work OK here */
  text-align: justify;
  /* Add more line-height increases legibility */
  line-height: 1.3;
  /* Just a tad border-radius to remove the sharp edges */
  border-radius: 2px;
}

  1. Maybe give things a little more vertical spacing.

  2. Maybe make the footer more prominent?

  3. justify is not a valid value for the position property.

#img-div {
  position: justify;
}
1 Like