Hello guys !
I really need your feedback about my last project in Responsive Web design
here’s the link: https://codepen.io/masmarmehdi/pen/mdEZKNP
i’ll be so thankful !!
please
Hi @mehdimasmar!
I think it looks good.
A few things.
-
There are a few errors in your html. Please run your code through the html validator https://validator.w3.org/
-
Your images for the projects section are not loading. If you want to have screenshots of your previous projects there is a way you can do that with codepen. https://blog.codepen.io/documentation/screenshots/
-
The icons at the bottom are misaligned.
Hope that helps!
Hey @mehdimasmar!
Your page looks good And the Font Choose is good.
but As @jwilkins.oboe Said you should change aligment of the Icon and etc…
Thanks and Happy Coding !
Hello @jwilkins.oboe !
I did run my code and they showed me only parse error in the body i didn’t get it and concerning the icons i’ll fix them
Thank you so much !
Thank youuu
If you look at the html validator report it will tell all of the errors and on what line they are in.
For example, one of the errors is that you have a duplicate id on line 31. Also in that same line you are missing an alt attribute.
You can ignore the the errors for doctype and head. But you can’t ignore the errors for duplicate ids and missing alt attributes.
Hope that makes sense.
Yes it does thank you so much!!!
Looks good @mehdimasmar. Something else to revisit;
I’m not seeing the images to your projects. In case you didn’t know,
- Codepen creates large and small screen shots of your pens that can be used in your portfolio. Access them from;
https://codepen.io/userName/pen/slug/image/large.png
(for the large screenshot)
or
https://codepen.io/userName/pen/slug/image/small.png
(for the small screenshot)- where you replace userName with your codepen userId and slug with the id of one of your codepen pens and then copy that link into your portfolio
Ohhh okeyy i understand thank you so much !!!
It was only after taking screenshots of my projects, resizing them to thumbnails, storing them in imgur.com and then using those in my project links that I read this
Sorry I didn’t understand what you wanted to say can you rephrase please?
Hi @mehdimasmar
My post was in response to @Roma’s post regarding how to create project screenshots on codepen, sorry if I wasn’t clear.
Regards,
Craig.
Oh yeah i see
To be fair it was a useful learning exercise and it does seem to work.
Also, I really like your profile page. Hopefully I can finish mine either later today or tomorrow.
That’s true
Thank you so much for your opinion and good luck for your project