Feedback and Advice on My Tribute Page

Code Feedback
1

https://codepen.io/danielemerald/pen/OJbKWPL

Hello, I’ve just finished my tribute page for the responsive web design certification. I’d really appreciate your feedback on the result, and maybe specifically on the sizing (@media), I think it’s still kind of messy, and not really satisfied with it. Thanks!

1 Like
2

Hi @danielemerald !

Welcome to the forum!

I think your page looks good.

I would review the lesson on giving links meaningful titles.
Wikipedia entry is not that accessible.

You have a couple of errors in your html.
Run your code through the [html validator] (The W3C Markup Validation Service)

Please do not use <br> tags like this
<br><br>
Use css instead to create space between elements.

Keep up the good work!

3

Your page is good @danielemerald but few things to revisit:

  1. Run your code through W3C Markup validator
  2. Do not use <br> tags to force line breaks
    Use css instead to create space between elements.
4

Hi @danielemerald:wave: Your page looks great :+1: but something to revisit:

  1. Run your code through W3C validator as jessica told you before.

  2. Keep all your style external.Do not use in-line styling. Give all those section a class name and use it in your stylesheet.

  3. The id value must be unique.Do not use duplicate id.
    FCC Learn Basic CSS:Set the id ofan element.

5

Thank you so much! I didn’t know about this validator before, and i find it really useful. I will keep in mind about the id and the br too :sweat_smile:

Thanks to @anon38330656 and @emanzulfiqar as well for the feedback

6

This topic was automatically closed 182 days after the last reply. New replies are no longer allowed.