Feedback/critique of my landing page project

Code Feedback
1

hi there
i’ve just finished the responsive web design project Landing Page for a Product. i would love some feedback on my code. please review and suggest some improvements if possible. thanks in advance
here’s the code https://codepen.io/strugglerz/pen/YzrXWeV

1 Like
2

Your page looks good @struggler. Some things to revisit;

  • Run your HTML code through the W3C validator.
    • There are HTML syntax/coding errors you should be aware of and address.
      Since copy/paste from codepen you can ignore the first warning and first two errors.
  • Codepen provides validators for HTML, CSS and JS. Click on the chevron in the upper right of each section and then click on the respective ‘Analyze’ link.
    • The one for CSS is good. Use it and address the issue(s).
      (The one for HTML misses things which is why I recommend W3C)
  • Check that the user has entered a valid email addr. Throw an HTML5 validation error if not.
    You learned to do this when coding the survey form
  • Make your page responsive. Remember, the R in RWD stands for Responsive
    • There’s a horizontal scrollbar on smaller screens
      Links in nav and footer run together
      Stack your price-boxes on smaller screens
      The video falls out of the container

For responsiveness you can start by styling for a narrow view port first. Narrow your browser as far as it will go and style the page so it looks good at that narrow width. Then gradually widen your browser and use CSS media query break points to adjust the style for wider view ports if needed.

3

@Roma thanks for the useful advice. I’ll try and implement these into the code and will revert back soon.

4

hey @Roma I’ve tried to make my page responsive. Here’s my code with the changes-https://codepen.io/strugglerz/pen/YzrXWeV.
Kindly review and respond.

5

That looks a lot better on smaller screens @struggler.

A couple of things;

  • The video does not resize so there is a horizontal scrollbar on smaller screens.
    Keep your styling external. Do not use in-line styling. (that will help you)
  • Don’t forget to clean up the errors in your HTML code after you run it through the W3C validator.
6

This topic was automatically closed 182 days after the last reply. New replies are no longer allowed.