!Feedback for my Tribute Page!


Total newbie to programming here, I have just completed my tribute page.

I would appreciate any feedback, mainly on the html and css.

Many Thanks

Welcome to the forums @ffiisshh. Your page looks good. Some things to revisit;

  • Codepen provides the boilerplate for you. It only expects the code you’d put within the body element in HTML. (No need to include the body tags). For anything you want to add to the <head> element click on the ‘Settings’ button, then HTML and add it into the ‘Stuff for <head>’ box.
    • The link to any font goes in the box labeled ‘Stuff for <head>’
  • Review the lesson about giving meaningful text to links.
    • Web Accessibility in Mind has a more thorough explanation.
    • “wikipedia page” is not accessible
    • blue text on a blue background isn’t accessible either

I don’t normally comment on someone’s style because it’s their own but;

  • That’s one huge paragraph. Worse still because it’s centered and there’s no padding on the sides so it butts right to the edges. It could be broken into multiple paragraphs for better UX.

As an aside, the eng value for the lang attribute is not a valid ISO language