Tribute Page Feedback - YC

Code Feedback
1

Hi All,
First time learning HTML and CSS and loving it.
Check out my tribute page and let me know what you think.

Thanks :slight_smile:

1 Like
2

Your page looks good @ysingch. Some things to revisit;

  • Codepen provides the boilerplate for you. It only expects the code you’d put within the body element in HTML. (No need to include the body tags). For anything you want to add to the <head> element click on the ‘Settings’ button, then HTML and add it into the ‘Stuff for <head>’ box.
    • The link to the font goes in the box labeled ‘Stuff for <head>’
  • Run your HTML code through the W3C validator.
    • There are HTML coding errors you should be aware of and address.
    • Since copy/paste from codepen you can ignore the first warning and first two errors.
  • Review the lesson about giving meaningful text to links.
  • Not sure if you noticed but user’s are not seeing your page the way you intended. You have strong elements around the dates but the dates are not bold. This is because when you linked the font you selected two light weights. You should also include a heavier bold weight (700).
  • Make your page responsive. Remember, the R in RWD stands for Responsive.
1 Like
3

@Roma Thank you for your quick, and super helpful feedback! :+1: I really appreciate it. Will fix all issues and update the link.

4

Glad to help @ysingch. Look forward to seeing it after you make changes.

5

Very good project @ysingch. I like it. It’s simple and I really like the color. But, it’s not responsive! :man_shrugging:

6

Hi @Roma
The updated page can be viewed here
I’ve updated the following items,

  • Put links in ‘Stuff for ’ box.
  • Run code through WSC validator
  • Update font links to include heavy weight
  • Make page responsive and stop content from falling out.

I updated the wiki link text to: “her wikipedia page” instead of “wikipedia”. But I am not sure if that’s accessible enough. The FCC example uses “wikipedia entry” as the text for link. What do you think?

7

Your page looks good @ysingch. Things to clear up;

  • Keep the test script when forking the pen (<script src="https://cdn.freecodecamp.org/testable-projects-fcc/v1/bundle.js"></script>).
    • The test script should be included, with all tests passing, when you submit your projects.
  • A better, accessible link could be " Read more about Eileen Chang". Don’t even need anything about wikipedia.

FCC’s sample page is not accessible either. The example pages are just guides on one way to do the project.
That is why I included the links to read.

Good job!

8

Thanks again! That makes sense. :+1:

1 Like
9