FCC-Tribute-Page Feedback

Code Feedback
1

Hi there,

I decided to take a deep dive finally into the Responsive Web Design on FreeCodeCamp. I took a week to go through the modules and alongside Google and reviewing the curriculum, I finally completed the first project in a couple of hours. I did the project as a tribute to one of my favorite artists.

Any feedback for anything at all I would appreciate!! Thank you!

FCC Tribute Page

2

Welcome to the forums @benjvminn. Your page looks good. Some things to revisit;

  • Codepen provides the boilerplate for you. It only expects the code you’d put within the body element in the HTML editor. (No need to include the body tags). For anything you want to add to the <head> element click on the ‘Settings’ button, then HTML and add it into the ‘Stuff for <head>’ box.
    For instance, links to fonts go in the box labeled ‘Stuff for <head>’
  • Run your HTML code through the W3C validator.
    There are HTML syntax/coding errors you should be aware of and address.
    Since copy/paste from codepen you can ignore the first warning and first two errors.
  • Do not use the <br> element to force line breaks or spacing. That’s what CSS is for.
    Reference MDN Docs
    Also, </br> is not a valid HTML tag
    If you want multiple paragraphs then use multiple paragraph elements.
  • Accessibility is about being accessible to all users. Review the giving meaningful text to links lesson. For a more thorough explanation read Web Accessibility in Mind.
    “wikipedia entry” is not accessible
  • Make your page responsive. Remember, the R in RWD stands for Responsive
    There’s a horizontal scrollbar on smaller screens
3

As Roma said, you should try running your HTML through a validator. You gave your HTML a wrong structure (like nesting a <body> tag inside <main>, it should be the other way around).

Appart from Roma’s advices, I would suggest to add some padding to the main paragraph since the text it’s too close to the borders. Also choosing a bigger font size would make it more readable (16px it’s a standard recomendation).

Hope this advices help you improve your project!

4

This topic was automatically closed 182 days after the last reply. New replies are no longer allowed.