Need tribute page feedback, please

Code Feedback
1

Hey fellow coders! I completed my first project. Can I please get some feedback? Thanks!

link to my tribute page

2

Welcome to the forum @KellyR. I took the liberty of renaming your post and putting the link in the body since people cannot click a title.

Your page looks good. Some things to revisit;

  • Verify your email addr with codepen so we can see your page full view
  • Run your HTML code through the W3C validator.
    • There are HTML syntax/coding errors you should be aware of and address.
    • Since copy/paste from codepen you can ignore the first warning and first two errors.
  • Codepen provides validators for HTML, CSS and JS. Click on the chevron in the upper right of each section and then click on the respective ‘Analyze’ link.
    • The one for CSS is good. Use it and address the issue(s).
    • (The one for HTML misses things which is why I recommend W3C)
  • Do not use the <br> element to force line breaks or spacing. That’s what CSS is for.
  • Accessibility is about being accessible to all users. Review the giving meaningful text to links lesson. For a more thorough explanation read Web Accessibility in Mind.
    • “here” is not accessible
  • Make your page responsive. Remember, the R in RWD stands for Responsive
    • There’s a horizontal scrollbar on smaller screens
3

Very helpful! Thank you so much!

1 Like
4

This topic was automatically closed 182 days after the last reply. New replies are no longer allowed.