Feedback for my tribute page :)

Code Feedback
1

Hey guys,

I have designed my first website as a part of the tribute page project. I am hoping to get some feedback from the FCC patrons.

Here is the codepen link to: https://codepen.io/sulsoyy/pen/GROMMqg

Thanks in advance for giving insightful feedback and happy Tuesday!

P.s I want to post my tribute page on Github and if anyone knows how to do that, please help me!!!

2

Welcome to the forums @sulsoyy. Your page looks good. Some things to revisit;

  • Verify your email addr with codepen so we can see your page full view
  • Codepen provides the boilerplate for you. It only expects the code you’d put within the body element in the HTML editor. (No need to include the body tags). For anything you want to add to the <head> element click on the ‘Settings’ button, then HTML and add it into the ‘Stuff for <head>’ box.
    What you have in the style element in the HTML editor can be placed in the CSS editor (without <style> </style> of course)
  • Run your HTML code through the W3C validator.
    There is an HTML syntax/coding error you should be aware of and address.
    Since copy/paste from codepen you can ignore the first warning and first two errors. (The other warnings are regarding semantics. You can review them but you don’t have to correct those right now.)
  • Do not use the <br> element to force line breaks or spacing. That’s what CSS is for.
    Reference MDN Docs
3

This topic was automatically closed 182 days after the last reply. New replies are no longer allowed.