Hey gang, first time using the forums. I finished the Survey Project awhile ago, and recently got back into fCC to try and clear the course by December(!) I recently finished the Tribute Project aswell. Any and all feedback is appreciated, thank you!
Survey Project:
Tribute Project:
Please only submit one project at a time and ideally ask for what kind of stuff you want feedback on.
I guess I’ll know for next time then. As for specific feedback, I don’t really have anything specific I’m looking for in terms of feedback, it’s a very new territory for me and I’m not particularly mindful of the common things to look out for as a beginner.
If i had to ask something specific, it would be I guess the quality of my code? What’s wasted effort and what’s bad practice?
Like I said, any and all criticism welcome.
Hello @forumWaters!
I’m sorry to see you haven’t gotten much feedback on your work yet. @a2937 is right, it is usually better to post only one project and give it a good description. That way we can focus in better on your work and in general, descriptions with questions and/or details make your post more interesting. I know this has worked in my experience.
Nice work. I hope you don’t mind me just reviewing your Survey Project. Going through code is a lot of work!
For the HTML:
<!DOCTYPE html>
<html lang="en">
<link rel="stylesheet" href="styles.css">
<head>
<meta charset="utf-8">
<title>Survey</title>
</head>
Your <link> element for the stylesheet needs to be nested inside the <head> element.
<fieldset>
<label id="note">Please, write your note.</label>
<textarea id=note rows="4" cols="40" placeholder="They should know your secrets"></textarea>
</fieldset>
Add a “for” attribute to your label element here - instead of an id attribute - that matches the id of your textarea element.
</form id="survey-form">
And up here, there is no need to add an id attribute to a closing tag.
Some of your input tags have additional closing tags. This is unnecessary - input elements are self-closing. I have listed the line numbers in your GitHub file below where the additional tags are located so you can fix them.
Line 23
Line 30
Line 39
Line 106
There is an unnecessary closing label tag on line 80.
On line 108 your closing tag on your h6 element isn’t quite right.
Also, your code’s format is quite messy - the indenting is scattered and it’s a bit hard to read. It’s easy to fix. Here’s the cleaned up code for you - the indenting is corrected, but I haven’t fixed the errors, of course 
<!DOCTYPE html>
<html lang="en">
<link rel="stylesheet" href="styles.css">
<head>
<meta charset="utf-8">
<title>Survey</title>
</head>
<body>
<h1 class="header" id="title">Judgement</h1>
<p class="header" id="description">Was it worth it?</p>
<div class="panel">
<form id="survey-form">
<fieldset class="info1">
<label id="name-label" for="name">
What do I call you?
<input type="text" placeholder=" Your parents named you that?" required id="name" name="name">
</input>
</label>
<label for="email" id="email-label">
Where does your mail go?
<input required type="email" placeholder="Check your spam folder" id="email" name="email">
</input>
</label>
<label for="number" id="number-label">
How long have you been here?
<input type="number" min="6" max="666" placeholder=" Aren't you too old?" id="number" name="number">
</input>
</label>
<label for="dropdown" id="dropdown-label">How did you get here?
<select name="dropdown" id="dropdown">
<option value="">I think it was...</option>
<option value="1"> It came to me in a dream</option>
<option value="2"><i>They</i> told me...</option>
<option value="3">The doctors</option>
</select>
</label>
</fieldset>
<fieldset>
<label for="choice-label">
What's your favorite thing?
</label>
<br>
<br>
<input name="choicePain" id="choicePain" class="choice" type="radio" value="1">Pain
<br>
<input name="choicePain" id="choiceCold" class="choice" type="radio" value="1">Cold
<br>
<input name="choicePain" id="choiceSour" class="choice" type="radio" value="1">Sour
<br>
<input name="choicePain" id="choiceSweet" class="choice" type="radio" value="1">Sweet
<br>
<input name="choicePain" id="choiceHope" class="choice" type="radio" value="1">Hope
<br>
<input name="choicePain" id="choiceLife" class="choice" type="radio" value="1">Life
</label>
</fieldset>
<fieldset>
<label id="punishment-label">
What do they deserve? (the more the merrier)
<br>
<br>
<input value=" " type=checkbox name="punishment" id="pain1" class="choice">Pain
<br>
<input value="1" type="checkbox" name="punishment" id="pain2" class="choice">Pain
<br>
<input value="2" type=checkbox name="punishment" id="pain3" class="choice">Pain
<br>
<input value="3" type="checkbox" name="punishment" id="pain4" class="choice">Pain
</label>
</fieldset>
<fieldset>
<label id="note">Please, write your note.</label>
<textarea id=note rows="4" cols="40" placeholder="They should know your secrets"></textarea>
</fieldset>
<input id="submit" type="submit" value="Get it over with"></input>
<h6>thanks for playing
<h6 />
</form id="survey-form">
</div>
</body>
</html>
For the CSS:
On line 18 you have a missing semi-colon.
background-color: rbga(0, 0, 0, 70)
WIDTH on line 35 - it doesn’t need to in all-caps.
WIDTH: 100%;
Another missing semi-colon on line 51.
background-color: black
On line 71 it should be rgba, not rgb, since you have an alpha value too. (90%)
background-color:rgb(23, 16, 16, 90%);
The CSS could be somewhat tidier as well, but in general you have formatted it well enough. Once in a while there are extra spaces and empty lines, but nothing problematic. I’m sure you can clean those up by yourself 
All in all well done. These are all minor syntax errors that we all make, so don’t worry about them. Just try to keep your code tidy and easy to read, and you’ll probably notice the errors yourself easier as well when everything is neat.
My compliments!
Happy coding,
Nicolas
Thank you very much for your feedback! Honestly if I could edit my op I probably would have just had the Survey project be the focus after a2937’s correction, considering it is the oldest. I had completely forgotten about for attributes!
Also thank you for the input on formatting, honestly, I think that’s something I struggle with the most and don’t really have a grasp of entirely. I think at some point when I started I found separating Attributes vertically to be easier to compartmentalize but didn’t think about how it would appear to a viewer, will definitely take these notes into account in the future.
Thank you again!