Feedback on tribute page and survey form

Code Feedback
1

tribute page:
https://codepen.io/rosewellcaitlin/full/xxGazjZ
survey:
https://codepen.io/rosewellcaitlin/full/Poqyzbd

1 Like
2

@rosewellcaitlin : Welcome to the forum:

I suggest to post your Survey and Tribute pages into the Feedback Place.

Grettins!!

1 Like
3

Tribute Page is pretty good. One tip though, you should use quote element around quotes instead of em. On Survey form use a different color palette and some spacing around elements.

1 Like
4

@fateslayer thank you for the feedback

1 Like
5

You are most welcome @rosewellcaitlin

1 Like
6

Hi @rosewellcaitlin, some things to revisit;
tribute page

  • On using codepen. codepen only expects the code you’d put within the <body> </body> tags in HTML. (No need to include the body tags). For anything you want to add to <head> click on the ‘Settings’ button, then HTML and add it into the ‘Stuff for <head>’ box.
    • You have a <body> tag after the header which causes a fatal error when run through the W3C validator
  • Don’t use the <br> element to force spacing or line breaks. Use margin and/or padding in CSS
  • you have duplicate header declarations in CSS

survey form

  • Run your HTML code through the W3C validator. Just copy your HTML and paste it into the ‘Validate by Direct Input’ tab.
    • Since copy/paste from codepen you can ignore the first warning and first two errors but clean up the other errors.
  • Do not use the <br> element to force spacing
    • There are ways to group like sections in your form. For instance, look at the <fieldset> element for your radio buttons and checkboxes.
  • change the cursor to a pointer when hovering over the submit button
  • In codepen you don’t need the <style> </style> tags in the CSS section, remove them.
  • I usually don’t comment on someone’s design but the red on black is really hard to read