Tribute page and Survey feedbacks

Code Feedback
1

Hello Guys below are my first two project.

Tribute page
https://codepen.io/Jose_Elias_Sanchez/pen/WNrRPdm

Suvey form
https://codepen.io/Jose_Elias_Sanchez/pen/PoZWVxx

Please any type of advise is pretty much welcome, I just want to improve as soon as I can.

1 Like
2

Animation on your first freeCodeCamp project? Cool!

1 Like
3

Both pages are looking good.Great Job!!!

1 Like
4

Pages looks good @Jose_Elias_Sanchez. Some things to revisit;
tribute

  • Codepen provides the boilerplate for you. It only expects the code you’d put within the body element in HTML. (No need to include the body tags). For anything you want to add to the <head> element click on the ‘Settings’ button, then HTML and add it into the ‘Stuff for <head>’ box.
    • Mentioning because you have elements placed incorrectly. Everything to browser renders belongs within the body element. That means header and footer. Also, to declare an HTML5 document it’s !DOCTYPE
  • Codepen provides validators for HTML, CSS and JS. Click on the down arrow in the upper right of each section and then click on the respective ‘Analyze’ link.
    • The one for HTML misses things which is why I recommend W3C
    • The one for CSS is good. Use it, there are things to clean up.
  • Make your page responsive. The video doesn’t scale which results in a horizontal scrollbar on smaller screens.

survey

  • Same as above re: using codepen properly and having elements placed incorrectly
  • Run your HTML code through the W3C validator.
    • Since copy/paste from codepen you can ignore the first warning and first two errors.
    • There are HTML coding errors you should address.
  • Don’t use <br> to force line breaks. That’s what CSS is for.
  • Users should be able to click on the label to select, not just the radio button / checkbox
  • Change the cursor to a pointer when hovering over the submit button
  • Side note, sans-serif is a fallback font. If that value appears first no other font will ever be selected.
1 Like
5

thank you that was really helpfull