Finished project

Code Feedback
1

Finished the first project of codecamp “tribute page” Don’t know if its normal in coding had to do a lot of back and forth and viewing other people’s codes and cheat sheets to remember to get this straight to pass… was a pain… but i want to show and get opinions and info how can improve and get better… thanks
Don’t know if this copy and paste works like code camp to proceed, but here it is.

2

Good job! There’s no shame in using all the resources necessary in order to get the job done, Doc!

3

Thanks brah lol :vulcan_salute:…

4

Yes it’s very very normal… you will always be looking at existing solutions to find out how to do something, treat these challenges like open-book projects and use whatever resources you want, the final challenges aren’t there to test your knowledge like a traditional exam but to stretch your knowledge and abilities as you build them.

The page looks great well done!

5

Just finished my first project too, so I guess it normal to go back and forth watching somebody else’s codes and works to understand better what is happening. No shame in looking for the “masters” works to find a better way to get the job done.

Good work, mate. Keep it up.

6

Encouraging … thanks

7

Thanks, seems like a long road, you as well

1 Like
8

Your page looks good @xaviergeorge99. Some things to revisit;

  • Codepen provides the boilerplate for you. It only expects the code you’d put within the body element in HTML. (No need to include the body tags). For anything you want to add to the <head> element click on the ‘Settings’ button, then HTML and add it into the ‘Stuff for <head>’ box.
    • Mentioning because all code the browser renders belongs in the body element. You have elements outside of it.
  • Run your HTML code through the W3C validator.
    • There are HTML coding errors you should be aware of and address.
    • Since copy/paste from codepen you can ignore the first warning and first two errors.
  • Codepen provides validators for HTML, CSS and JS. Click on the down arrow in the upper right of each section and then click on the respective ‘Analyze’ link.
    • The one for CSS is good. Use it, there’s something to clean up.
      • When you fix the first error run it again. There’s another. Keep running it until there are no errors.
    • (The one for HTML misses things which is why I recommend W3C)
  • Review the lesson about giving meaningful text to links.
  • Make the page responsive. Rather than hardcoding pixel values it’s easier for a page to be responsive if values were a percentage width. This is what I see on a narrow screen;
    Screen Shot 2020-09-26 at 13.09.27
    Screen Shot 2020-09-26 at 13.09.27501×644 11.4 KB
9

Will get on it, Thanks thank you for constructive criticism…