I Made My First Project (Tribute Page)

Code Feedback
1

Hello everyone, I just finished my first project of the reponsive web design curriculum,
when I saw the final page I felt that emotion like “I DID IT”, I don’t know how to explain, it just hits me different haha.

I’m a complete beginner so I likely have a lot of stuff to improve and I wanna ask you for suggestions.

Tribute Page

2

Welcome to the forums @costamarcos404. Your page looks good. Some things to revisit;

  • Keep the test script when forking the pen (<script src="https://cdn.freecodecamp.org/testable-projects-fcc/v1/bundle.js"></script>)
    • The test script, with all tests passing, should be included when you submit your projects.
    • Your page passes 9/10 user stories. Click the red button to see which test(s) are failing and text to help you correct the issue.
    • Be sure and read more than just the first line of the failing message. The ability to read and comprehend error messages is a skill you’ll need to acquire as a developer. Ask questions on what you don’t understand.
  • Run your HTML code through the W3C validator.
    • There are HTML syntax/coding errors you should be aware of and address.
    • Since copy/paste from codepen you can ignore the first warning and first two errors.
  • In addition to being used incorrectly in your page, do not use the <br> element to force line breaks or spacing. That’s what CSS is for.
3

Thanks a lot by the feedback, I’m going to fix these issues and try to improve it on next pŕojects. And actually I didn’t fork the pen, I started one from scratch haha, so that’s why I haven’t that script lol.

4

If you have time look at my pen again, I tried to solve all those problems, just three that I’m aware of and you may still see on W3C validator is a lack of these tags:

<!DOCTYPE html>
<html lang="eng">
    <head>
        <title></title>
    </head>
</html>

I mean, by defaut codepen already has all those things so I don’t have to set them again, if you know how to change codepen’s preview template let me know, also thanks to help me to improve my knowledge and skills, I’m so glad you helped.

5

It looks good @costamarcos404. Nice job cleaning things up.

Side note, the test script would typically go right before the closing body tag, not in the body. For codepen you can have it as the first line (or last) in the HTML editor.

Yes, that is why in my feedback to you about using the W3C validator the last bullet point says Since copy/paste from codepen you can ignore the first warning and first two errors.

Glad to have helped.

Have fun with the next project. Look forward to seeing it.

6

This topic was automatically closed 182 days after the last reply. New replies are no longer allowed.