First web page! Tribute page!

Code Feedback
1

So this is my first page, im kinda excited for the next challenges!
What do you guys think? Would Will Smith be proud? haha
https://codepen.io/aiden22/pen/qBqmOje
p.s. Im really bad at picking colors

3 Likes
2

Your page looks good @Aiden22. Some things to revisit;

  • Keep the test script when forking the pen (<script src="https://cdn.freecodecamp.org/testable-projects-fcc/v1/bundle.js"></script>)
    • The test script, with all tests passing, should be included when you submit your projects.
    • Your page passes 9/10 user stories. Click the red button to see which test(s) are failing and text to help you correct the issue.
    • Be sure and read more than just the first line of the failing message. The ability to read and comprehend error messages is a skill you’ll need to acquire as a developer. Ask questions on what you don’t understand.
  • Codepen provides the boilerplate for you. It only expects the code you’d put within the body element in the HTML editor. (No need to include the body tags). For anything you want to add to the <head> element click on the ‘Settings’ button, then HTML and add it into the ‘Stuff for <head>’ box.
  • Run your HTML code through the W3C validator.
    • There are HTML coding errors you should be aware of and address.
    • Since copy/paste from codepen you can ignore the first warning and first two errors.
  • Codepen provides validators for HTML, CSS and JS. Click on the chevron in the upper right of each section and then click on the respective ‘Analyze’ link.
    • The one for CSS is good. Use it and address the issue(s).
    • (The one for HTML misses things which is why I recommend W3C)
  • Do not use the <br> element to force line breaks or spacing. That’s what CSS is for.
  • Accessibility is about being accessible to all users. Review the lesson about giving meaningful text to links. For a more thorough explanation read Web Accessibility in Mind.
    • “here” is not accessible
1 Like
3

Thanks for the feedback @Roma . I fixed every point! Thanks for the new tools you gave me (didn’t know about the w3c validator and the codepen one). Hope now it looks better :grinning:
https://codepen.io/aiden22/full/qBqmOje
Have a nice day!

1 Like
4

Nice job cleaning things up @Aiden22.

Look forward to seeing your next project.

5

I know it’s late but your page is beautiful, you mix the colours really good. I’m impress your caption can be on the image because I can’t do that and it makes your website more professional. But I think you should change your fonts, and maybe use :hover at the Click More one. That’s my feedback, sorry because I can’t tell you about your code because I’m not a pro but overall, your tribute page looks incredible and amazing. Looking forward to see more projects from you :slight_smile:

1 Like
6

It’s a good page with an interesting choice for the character :slight_smile: I see you posted on February, I think you can do even a better version when you will feel ready :slight_smile: Keep up the good work!