Feedback please on my Tribute Page :)

Please provide any feedback on my Tribute page, thank you!

1 Like

HI @tyui78 !

Congrats on finishing the tribute page!

A few comments regarding the code.

In codepen, you don’t need to include the html tags because that is already built into codepen. I think better tag to use here would be the main tags.

<html id="main">

Be careful here, because img tags are self closing and don’t have end tags.

  <img id="image" src=""
         alt="decorative image"

For your html, I would suggest formatting your code using codepen’s built in tool.

Hope that helps!

Thanks for the feedback!

I have enacted the tips you have provided.

How come when I change my HTML tags to main tags, there is now a white box around the page?

Initially you wrote this.

<html id="main">

Which meant the entire background for the document was orange

#main {
  text-align: center;
  background-color: orange;

If you still want to use main tags and have the background be orange, you can apply that to the body selector like this.

<main id="main">
    background-color: orange;

But something I missed the first time looking at your project is this part for smaller screens

Right now you have the image set to a max width of 500 px

  max-width: 500px;

That is going to be an issue for screens small than 500px.
You will need to adjust that so your image looks good on all screen sizes.

Hope that helps!

I have updated the main tags as well have updated the image to be max-width: 100% so it looks good even on small screens.

Good Job fixing the Dimensions at the smaller screen widths.

My suggestions to You on this project will be pretty similar to the Queer Eye Survey.

FIRST: I think you should chose a color palette that works well with the image:

SECOND: I think you should consider adding padding to your text, and changing the numbers to remove the unnecessary Zeros.


dl {
  background-color: #192327;
  max-width: 1000px;
  margin: 0 auto;
  border: 0px solid #192327;
  padding: 2% 4% 0 0;
  text-align: center;
  width: 80%;

Thanks Alless!

I have enacted your feedback.

Good color Choice. A Very Dinosaur-ish Color palette. : )

This topic was automatically closed 182 days after the last reply. New replies are no longer allowed.