Hi guys, check out my first Project: Tribute Page

Code Feedback
1

Please click on the link below and give me your feedback:
https://codepen.io/Mikchuma/full/wvgxzRa

4 Likes
2

my only feedback is that it is uniquely designed with your own design marks and styles, so :+1: my friend

1 Like
4

Thanks very much for your feedback

5

This is a good start. My only suggestion is to remove the margin from the html and body element so you don’t get the white border effect from the native styling.

css

html {
	font-size: 10px;
  padding: 0;
  margin: 0;
}

body {
  padding: 0;
  margin: 0;
}

...

#main {
	font-family: Arial, monospace, sans-serif;
  	font-size: 1.6rem;
  	line-height: 2;
  	text-align: center;
  	margin: 0;  /* set this to zero to remove the margin */
  	padding: 15px;
  	border-radius: 5px;
  	background: #00FFFF;
}
6

Thanks friend for your feedback

7

Welcome to the forums @MikChuma. Your page looks good. Some things to revisit;

  • Keep the test script when forking the pen (<script src="https://cdn.freecodecamp.org/testable-projects-fcc/v1/bundle.js"></script>)
    • The test script, with all tests passing, should be included when you submit your projects.
  • Run your HTML code through the W3C validator.
    • There are HTML syntax/coding errors you should be aware of and address. (Small typo to clean up)
    • Since copy/paste from codepen you can ignore the first warning and first two errors.
2 Likes
8

Thanks a lot for your feedback. The concerns have been fixed

9

Looks good @MikChuma.

Just so you’re aware, the test script is JS and relies on the page being loaded to run properly. It should be placed right before the closing body tag.
It works where it is in codepen only because codepen is forgiving.

On a side note, codepen provides the boilerplate for you. It only expects the code you’d put within the body element in the HTML editor. (No need to include the body tags). For anything you want to add to the <head> element click on the ‘Settings’ button, then HTML and add it into the ‘Stuff for <head>’ box.

2 Likes
10

Thanks for the correction.

1 Like
11

Glad to help.

Look forward to seeing your next project.

1 Like
12

Hey @MikChuma, very cool to learn about Chinua Achebe! I really liked your page, and wanted to show you my work on another interesting Nigerian: https://codepen.io/ghersf91/full/gOLeboy

Kind regards!

13

Thank you @ghersf91 for sharing, You have a great work there. Just followed you on Codepen

1 Like
14

This topic was automatically closed 182 days after the last reply. New replies are no longer allowed.